2016-12-21 02:20:21 +00:00
|
|
|
From 23133db85174d33389eae98c13e2f65c9ef05215 Mon Sep 17 00:00:00 2001
|
2016-11-13 01:53:28 +00:00
|
|
|
From: Arnd Bergmann <arnd@arndb.de>
|
|
|
|
|
Date: Tue, 10 May 2016 23:30:01 +0200
|
2016-12-21 02:20:21 +00:00
|
|
|
Subject: [PATCH 1/9] kbuild: move -Wunused-const-variable to W=1 warning level
|
2016-11-13 01:53:28 +00:00
|
|
|
|
|
|
|
|
gcc-6 started warning by default about variables that are not
|
|
|
|
|
used anywhere and that are marked 'const', generating many
|
|
|
|
|
false positives in an allmodconfig build, e.g.:
|
|
|
|
|
|
|
|
|
|
arch/arm/mach-davinci/board-da830-evm.c:282:20: warning: 'da830_evm_emif25_pins' defined but not used [-Wunused-const-variable=]
|
|
|
|
|
arch/arm/plat-omap/dmtimer.c:958:34: warning: 'omap_timer_match' defined but not used [-Wunused-const-variable=]
|
|
|
|
|
drivers/bluetooth/hci_bcm.c:625:39: warning: 'acpi_bcm_default_gpios' defined but not used [-Wunused-const-variable=]
|
|
|
|
|
drivers/char/hw_random/omap-rng.c:92:18: warning: 'reg_map_omap4' defined but not used [-Wunused-const-variable=]
|
|
|
|
|
drivers/devfreq/exynos/exynos5_bus.c:381:32: warning: 'exynos5_busfreq_int_pm' defined but not used [-Wunused-const-variable=]
|
|
|
|
|
drivers/dma/mv_xor.c:1139:34: warning: 'mv_xor_dt_ids' defined but not used [-Wunused-const-variable=]
|
|
|
|
|
|
|
|
|
|
This is similar to the existing -Wunused-but-set-variable warning
|
|
|
|
|
that was added in an earlier release and that we disable by default
|
|
|
|
|
now and only enable when W=1 is set, so it makes sense to do
|
|
|
|
|
the same here. Once we have eliminated the majority of the
|
|
|
|
|
warnings for both, we can put them back into the default list.
|
|
|
|
|
|
|
|
|
|
We probably want this in backport kernels as well, to allow building
|
|
|
|
|
them with gcc-6 without introducing extra warnings.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
|
|
|
|
|
Acked-by: Olof Johansson <olof@lixom.net>
|
|
|
|
|
Acked-by: Lee Jones <lee.jones@linaro.org>
|
|
|
|
|
Cc: stable@vger.kernel.org
|
|
|
|
|
Signed-off-by: Michal Marek <mmarek@suse.com>
|
|
|
|
|
---
|
|
|
|
|
Makefile | 5 +++--
|
|
|
|
|
scripts/Makefile.extrawarn | 1 +
|
|
|
|
|
2 files changed, 4 insertions(+), 2 deletions(-)
|
|
|
|
|
|
|
|
|
|
diff --git a/Makefile b/Makefile
|
|
|
|
|
index b52a844..4053d1ca 100644
|
|
|
|
|
--- a/Makefile
|
|
|
|
|
+++ b/Makefile
|
|
|
|
|
@@ -707,9 +707,10 @@ KBUILD_CFLAGS += $(call cc-option, -mno-global-merge,)
|
|
|
|
|
KBUILD_CFLAGS += $(call cc-option, -fcatch-undefined-behavior)
|
|
|
|
|
else
|
|
|
|
|
|
|
|
|
|
-# This warning generated too much noise in a regular build.
|
|
|
|
|
-# Use make W=1 to enable this warning (see scripts/Makefile.build)
|
|
|
|
|
+# These warnings generated too much noise in a regular build.
|
|
|
|
|
+# Use make W=1 to enable them (see scripts/Makefile.build)
|
|
|
|
|
KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
|
|
|
|
|
+KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
ifdef CONFIG_FRAME_POINTER
|
|
|
|
|
diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
|
|
|
|
|
index f734033..5c17a5c 100644
|
|
|
|
|
--- a/scripts/Makefile.extrawarn
|
|
|
|
|
+++ b/scripts/Makefile.extrawarn
|
|
|
|
|
@@ -24,6 +24,7 @@ warning-1 += $(call cc-option, -Wmissing-prototypes)
|
|
|
|
|
warning-1 += -Wold-style-definition
|
|
|
|
|
warning-1 += $(call cc-option, -Wmissing-include-dirs)
|
|
|
|
|
warning-1 += $(call cc-option, -Wunused-but-set-variable)
|
|
|
|
|
+warning-1 += $(call cc-option, -Wunused-const-variable)
|
|
|
|
|
warning-1 += $(call cc-disable-warning, missing-field-initializers)
|
|
|
|
|
|
|
|
|
|
warning-2 := -Waggregate-return
|
|
|
|
|
--
|
|
|
|
|
2.10.2
|
|
|
|
|
|
