From 4bfee656740d6f6a28cc822cf781bffac1c1ca24 Mon Sep 17 00:00:00 2001 From: Jose Dapena Paz Date: Mon, 5 Mar 2018 14:19:54 +0000 Subject: [PATCH 3/7] GCC build fix: base::Optional requires the full declaration of T MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In GCC 7.2/7.3, base::Optional fails to compile, if T has still only been forward declared, as it cannot properly resolve the is_trivially_* declarations. In this case it is needed to include the full declaration of the type, and not only the forward declaration. Change-Id: I63e5c6307394c6c2eda6af108c80395152bfc04f Reviewed-on: https://chromium-review.googlesource.com/944401 Commit-Queue: José Dapena Paz Reviewed-by: Bernhard Bauer Cr-Commit-Position: refs/heads/master@{#540815} --- services/preferences/tracked/pref_hash_filter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/preferences/tracked/pref_hash_filter.h b/services/preferences/tracked/pref_hash_filter.h index c425aee850dd..2bad7bb5ce8b 100644 --- a/services/preferences/tracked/pref_hash_filter.h +++ b/services/preferences/tracked/pref_hash_filter.h @@ -21,9 +21,9 @@ #include "services/preferences/public/mojom/preferences.mojom.h" #include "services/preferences/tracked/hash_store_contents.h" #include "services/preferences/tracked/interceptable_pref_filter.h" +#include "services/preferences/tracked/pref_hash_store.h" #include "services/preferences/tracked/tracked_preference.h" -class PrefHashStore; class PrefService; namespace base { -- 2.17.0