mirror of
https://github.com/archlinuxarm/PKGBUILDs.git
synced 2024-11-08 22:45:43 +00:00
94 lines
2.9 KiB
Diff
94 lines
2.9 KiB
Diff
Description: fix memory disclosure in TLS heartbeat extension
|
|
Origin: upstream, http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=96db9023b881d7cd9f379b0c154650d6c108e9a3
|
|
|
|
Index: openssl-1.0.1f/ssl/d1_both.c
|
|
===================================================================
|
|
--- openssl-1.0.1f.orig/ssl/d1_both.c 2014-01-06 08:47:42.000000000 -0500
|
|
+++ openssl-1.0.1f/ssl/d1_both.c 2014-04-07 15:37:38.548342862 -0400
|
|
@@ -1459,26 +1459,36 @@
|
|
unsigned int payload;
|
|
unsigned int padding = 16; /* Use minimum padding */
|
|
|
|
- /* Read type and payload length first */
|
|
- hbtype = *p++;
|
|
- n2s(p, payload);
|
|
- pl = p;
|
|
-
|
|
if (s->msg_callback)
|
|
s->msg_callback(0, s->version, TLS1_RT_HEARTBEAT,
|
|
&s->s3->rrec.data[0], s->s3->rrec.length,
|
|
s, s->msg_callback_arg);
|
|
|
|
+ /* Read type and payload length first */
|
|
+ if (1 + 2 + 16 > s->s3->rrec.length)
|
|
+ return 0; /* silently discard */
|
|
+ hbtype = *p++;
|
|
+ n2s(p, payload);
|
|
+ if (1 + 2 + payload + 16 > s->s3->rrec.length)
|
|
+ return 0; /* silently discard per RFC 6520 sec. 4 */
|
|
+ pl = p;
|
|
+
|
|
if (hbtype == TLS1_HB_REQUEST)
|
|
{
|
|
unsigned char *buffer, *bp;
|
|
+ unsigned int write_length = 1 /* heartbeat type */ +
|
|
+ 2 /* heartbeat length */ +
|
|
+ payload + padding;
|
|
int r;
|
|
|
|
+ if (write_length > SSL3_RT_MAX_PLAIN_LENGTH)
|
|
+ return 0;
|
|
+
|
|
/* Allocate memory for the response, size is 1 byte
|
|
* message type, plus 2 bytes payload length, plus
|
|
* payload, plus padding
|
|
*/
|
|
- buffer = OPENSSL_malloc(1 + 2 + payload + padding);
|
|
+ buffer = OPENSSL_malloc(write_length);
|
|
bp = buffer;
|
|
|
|
/* Enter response type, length and copy payload */
|
|
@@ -1489,11 +1499,11 @@
|
|
/* Random padding */
|
|
RAND_pseudo_bytes(bp, padding);
|
|
|
|
- r = dtls1_write_bytes(s, TLS1_RT_HEARTBEAT, buffer, 3 + payload + padding);
|
|
+ r = dtls1_write_bytes(s, TLS1_RT_HEARTBEAT, buffer, write_length);
|
|
|
|
if (r >= 0 && s->msg_callback)
|
|
s->msg_callback(1, s->version, TLS1_RT_HEARTBEAT,
|
|
- buffer, 3 + payload + padding,
|
|
+ buffer, write_length,
|
|
s, s->msg_callback_arg);
|
|
|
|
OPENSSL_free(buffer);
|
|
Index: openssl-1.0.1f/ssl/t1_lib.c
|
|
===================================================================
|
|
--- openssl-1.0.1f.orig/ssl/t1_lib.c 2014-01-06 08:47:42.000000000 -0500
|
|
+++ openssl-1.0.1f/ssl/t1_lib.c 2014-04-07 15:37:38.548342862 -0400
|
|
@@ -2558,16 +2558,20 @@
|
|
unsigned int payload;
|
|
unsigned int padding = 16; /* Use minimum padding */
|
|
|
|
- /* Read type and payload length first */
|
|
- hbtype = *p++;
|
|
- n2s(p, payload);
|
|
- pl = p;
|
|
-
|
|
if (s->msg_callback)
|
|
s->msg_callback(0, s->version, TLS1_RT_HEARTBEAT,
|
|
&s->s3->rrec.data[0], s->s3->rrec.length,
|
|
s, s->msg_callback_arg);
|
|
|
|
+ /* Read type and payload length first */
|
|
+ if (1 + 2 + 16 > s->s3->rrec.length)
|
|
+ return 0; /* silently discard */
|
|
+ hbtype = *p++;
|
|
+ n2s(p, payload);
|
|
+ if (1 + 2 + payload + 16 > s->s3->rrec.length)
|
|
+ return 0; /* silently discard per RFC 6520 sec. 4 */
|
|
+ pl = p;
|
|
+
|
|
if (hbtype == TLS1_HB_REQUEST)
|
|
{
|
|
unsigned char *buffer, *bp;
|