From 01367faa396190484e8da2ca652635ccabe55476 Mon Sep 17 00:00:00 2001 From: Yury Molodov Date: Sun, 12 Mar 2023 11:09:56 +0100 Subject: [PATCH] vmui: remove send step param for instant queries (#3931) * fix: remove step param for instant queries (#3896) * vmui: remove send step param for instant queries * Update docs/CHANGELOG.md --------- Co-authored-by: Aliaksandr Valialkin --- app/vmui/packages/vmui/src/api/query-range.ts | 2 +- docs/CHANGELOG.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/vmui/packages/vmui/src/api/query-range.ts b/app/vmui/packages/vmui/src/api/query-range.ts index c89e43d01b..850760fe8c 100644 --- a/app/vmui/packages/vmui/src/api/query-range.ts +++ b/app/vmui/packages/vmui/src/api/query-range.ts @@ -4,6 +4,6 @@ export const getQueryRangeUrl = (server: string, query: string, period: TimePara `${server}/api/v1/query_range?query=${encodeURIComponent(query)}&start=${period.start}&end=${period.end}&step=${period.step}${nocache ? "&nocache=1" : ""}${queryTracing ? "&trace=1" : ""}`; export const getQueryUrl = (server: string, query: string, period: TimeParams, queryTracing: boolean): string => - `${server}/api/v1/query?query=${encodeURIComponent(query)}&time=${period.end}&step=${period.step}${queryTracing ? "&trace=1" : ""}`; + `${server}/api/v1/query?query=${encodeURIComponent(query)}&time=${period.end}${queryTracing ? "&trace=1" : ""}`; export const getQueryOptions = (server: string) => `${server}/api/v1/label/__name__/values`; diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index ef949568b7..b0662b3171 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -33,6 +33,7 @@ The following tip changes can be tested by building VictoriaMetrics components f * BUGFIX: [vmui](https://docs.victoriametrics.com/#vmui): stop showing `Please enter a valid Query and execute it` error message on the first load of vmui. * BUGFIX: [vmui](https://docs.victoriametrics.com/#vmui): properly process `Run in VMUI` button click in [VictoriaMetrics datasource plugin for Grafana](https://github.com/VictoriaMetrics/grafana-datasource). * BUGFIX: [vmui](https://docs.victoriametrics.com/#vmui): fix the display of the selected value for dropdowns on `Explore` page. +* BUGFIX: [vmui](https://docs.victoriametrics.com/#vmui): do not send `step` param for instant queries. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3896). * BUGFIX: [vmauth](https://docs.victoriametrics.com/vmauth.html): fix `cannot serve http` panic when plain HTTP request is sent to `vmauth` configured to accept requests over [proxy protocol](https://www.haproxy.org/download/2.3/doc/proxy-protocol.txt)-encoded request (e.g. when `vmauth` runs with `-httpListenAddr.useProxyProtocol` command-line flag). The issue has been introduced at [v1.87.0](https://docs.victoriametrics.com/CHANGELOG.html#v1870) when implementing [this feature](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3335). * BUGFIX: [vmgateway](https://docs.victoriametrics.com/vmgateway.html): properly parse RSA public key discovered via JWK endpoint.