From 1152c30430daa464a16a4221ad9007d1af5da236 Mon Sep 17 00:00:00 2001 From: hagen1778 Date: Mon, 16 Oct 2023 16:00:24 +0200 Subject: [PATCH] app/vmagent/remotewrite: follow-up after 4f102ff945e8def8db8a74ab67d762d17e1139e5 https://github.com/VictoriaMetrics/VictoriaMetrics/commit/4f102ff945e8def8db8a74ab67d762d17e1139e5 Signed-off-by: hagen1778 --- app/vmagent/remotewrite/remotewrite.go | 5 +++-- docs/CHANGELOG.md | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/vmagent/remotewrite/remotewrite.go b/app/vmagent/remotewrite/remotewrite.go index 31f32267e..ccd7a77be 100644 --- a/app/vmagent/remotewrite/remotewrite.go +++ b/app/vmagent/remotewrite/remotewrite.go @@ -742,13 +742,14 @@ func (rwctx *remoteWriteCtx) pushInternal(tss []prompbmarshal.TimeSeries) { } func (rwctx *remoteWriteCtx) reinitStreamAggr() { - sas := rwctx.sas.Load() - sasFile := streamAggrConfig.GetOptionalArg(rwctx.idx) if sasFile == "" { // There is no stream aggregation for rwctx return } + + sas := rwctx.sas.Load() + logger.Infof("reloading stream aggregation configs pointed by -remoteWrite.streamAggr.config=%q", sasFile) metrics.GetOrCreateCounter(fmt.Sprintf(`vmagent_streamaggr_config_reloads_total{path=%q}`, sasFile)).Inc() dedupInterval := streamAggrDedupInterval.GetOptionalArg(rwctx.idx) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 6a037ad97..c82622a18 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -52,6 +52,7 @@ The sandbox cluster installation is running under the constant load generated by * BUGFIX: dashboards: fix vminsert/vmstorage/vmselect metrics filtering when dashboard is used to display data from many sub-clusters with unique job names. Before, only one specific job could have been accounted for component-specific panels, instead of all available jobs for the component. * BUGFIX: [VictoriaMetrics cluster](https://docs.victoriametrics.com/Cluster-VictoriaMetrics.html): bump hard-coded limit for search query size at `vmstorage` from 1MB to 5MB. The change should be more suitable for real-world scenarios and protect vmstorage from excessive memory usage. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5154) for details * BUGFIX: [vmbackup](https://docs.victoriametrics.com/vmbackup.html): fix error when creating an incremental backup with the `-origin` command-line flag. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5144) for details. +* BUGFIX: [vmagent](https://docs.victoriametrics.com/vmagent.html): fix vmagent ignoring configuration reload for streaming aggregation if it was started with empty streaming aggregation config. Thanks to @aluode99 for the [pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5178). ## [v1.94.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.94.0)