From 149511f5e9a5985adb99e707ba139494b1ddd251 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 15 Dec 2020 13:13:46 +0200 Subject: [PATCH] Do not set `GO111MODULE=off` during `go install`, since this doesnt work in Go1.14 and Go1.15 --- .github/workflows/main.yml | 2 -- Makefile | 6 +++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4662926ee..059504c1b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -19,8 +19,6 @@ jobs: go-version: 1.15 id: go - name: Dependencies - env: - GO111MODULE: off run: | go install golang.org/x/lint/golint go install github.com/kisielk/errcheck diff --git a/Makefile b/Makefile index b20c241fa..53307e25a 100644 --- a/Makefile +++ b/Makefile @@ -80,7 +80,7 @@ lint: install-golint golint app/... install-golint: - which golint || GO111MODULE=off go install golang.org/x/lint/golint + which golint || go install golang.org/x/lint/golint errcheck: install-errcheck errcheck -exclude=errcheck_excludes.txt ./lib/... @@ -94,7 +94,7 @@ errcheck: install-errcheck errcheck -exclude=errcheck_excludes.txt ./app/vmrestore/... install-errcheck: - which errcheck || GO111MODULE=off go install github.com/kisielk/errcheck + which errcheck || go install github.com/kisielk/errcheck check-all: fmt vet lint errcheck golangci-lint @@ -140,7 +140,7 @@ quicktemplate-gen: install-qtc qtc install-qtc: - which qtc || GO111MODULE=off go install github.com/valyala/quicktemplate/qtc + which qtc || go install github.com/valyala/quicktemplate/qtc golangci-lint: install-golangci-lint