github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-03-11 15:34:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

vmselect: fix result collect count (#4599)

Browse source
This commit is contained in:
Haleygo 2023-07-08 14:21:27 +08:00 committed by GitHub
parent 173ccf4333
commit 14e242d0b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/vmselect/netstorage/netstorage.go
View file

@ -1729,7 +1729,6 @@ func (snr *storageNodesRequest) collectResults(partialResultsCounter *metrics.Co
result := <-snr.resultsCh result := <-snr.resultsCh
if err := f(result.data); err != nil { if err := f(result.data); err != nil {
snr.finishQueryTracer(result.qt, fmt.Sprintf("error: %s", err)) snr.finishQueryTracer(result.qt, fmt.Sprintf("error: %s", err))
resultsCollected++
if *skipSlowReplicas && resultsCollected > len(sns)-*replicationFactor { if *skipSlowReplicas && resultsCollected > len(sns)-*replicationFactor {
// There is no need in waiting for the remaining results, // There is no need in waiting for the remaining results,
// because the collected results contain all the data according to the given -replicationFactor. // because the collected results contain all the data according to the given -replicationFactor.
@ -1767,6 +1766,7 @@ func (snr *storageNodesRequest) collectResults(partialResultsCounter *metrics.Co
continue continue
} }
snr.finishQueryTracer(result.qt, "") snr.finishQueryTracer(result.qt, "")
resultsCollected++
} }
if len(errsPartial) < *replicationFactor { if len(errsPartial) < *replicationFactor {
// Assume that the result is full if the the number of failing vmstorage nodes // Assume that the result is full if the the number of failing vmstorage nodes