From 19b189e9b7238f1093b03535575229908d385abf Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Sun, 2 Apr 2023 21:35:34 -0700 Subject: [PATCH] lib/storage: use shorter code after 03bde173b77215345abeb646a436820a27ce749c --- lib/storage/storage.go | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/storage/storage.go b/lib/storage/storage.go index c855df8f9c..954fe264fb 100644 --- a/lib/storage/storage.go +++ b/lib/storage/storage.go @@ -1851,12 +1851,13 @@ type pendingMetricRows struct { } func (pmrs *pendingMetricRows) reset() { - for i := range pmrs.pmrs { - pmr := &pmrs.pmrs[i] + mrs := pmrs.pmrs + for i := range mrs { + pmr := &mrs[i] pmr.MetricName = nil pmr.mr = nil } - pmrs.pmrs = pmrs.pmrs[:0] + pmrs.pmrs = mrs[:0] pmrs.metricNamesBuf = pmrs.metricNamesBuf[:0] pmrs.lastMetricNameRaw = nil pmrs.lastMetricName = nil @@ -1876,12 +1877,14 @@ func (pmrs *pendingMetricRows) addRow(mr *MetricRow) error { pmrs.lastMetricName = pmrs.metricNamesBuf[metricNamesBufLen:] pmrs.lastMetricNameRaw = mr.MetricNameRaw } - if cap(pmrs.pmrs) > len(pmrs.pmrs) { - pmrs.pmrs = pmrs.pmrs[:len(pmrs.pmrs)+1] + mrs := pmrs.pmrs + if cap(mrs) > len(mrs) { + mrs = mrs[:len(mrs)+1] } else { - pmrs.pmrs = append(pmrs.pmrs, pendingMetricRow{}) + mrs = append(mrs, pendingMetricRow{}) } - pmr := &pmrs.pmrs[len(pmrs.pmrs)-1] + pmrs.pmrs = mrs + pmr := &mrs[len(mrs)-1] pmr.MetricName = pmrs.lastMetricName pmr.mr = mr return nil