github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vmbackup/snapshot: add missing status code check for the returned response when working with snapshot API

Browse source 
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/929
This commit is contained in:
Aliaksandr Valialkin 2020-11-30 14:49:07 +02:00
parent d5ba66c303
commit 1dce37b2fa
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/vmbackup/snapshot/snapshot.go
View file

@ -25,16 +25,17 @@ func Create(createSnapshotURL string) (string, error) {
if err != nil { if err != nil {
return "", err return "", err
} }
resp, err := http.Get(u.String()) resp, err := http.Get(u.String())
if err != nil { if err != nil {
return "", err return "", err
} }
body, err := ioutil.ReadAll(resp.Body) body, err := ioutil.ReadAll(resp.Body)
if err != nil { if err != nil {
return "", err return "", err
} }
if resp.StatusCode != http.StatusOK {
return "", fmt.Errorf("unexpected status code returned from %q; expecting %d; got %d; response body: %q", createSnapshotURL, resp.StatusCode, http.StatusOK, body)
}
snap := snapshot{} snap := snapshot{}
err = json.Unmarshal(body, &snap) err = json.Unmarshal(body, &snap)
@ -58,21 +59,21 @@ func Delete(deleteSnapshotURL string, snapshotName string) error {
formData := url.Values{ formData := url.Values{
"snapshot": {snapshotName}, "snapshot": {snapshotName},
} }
u, err := url.Parse(deleteSnapshotURL) u, err := url.Parse(deleteSnapshotURL)
if err != nil { if err != nil {
return err return err
} }
resp, err := http.PostForm(u.String(), formData) resp, err := http.PostForm(u.String(), formData)
if err != nil { if err != nil {
return err return err
} }
body, err := ioutil.ReadAll(resp.Body) body, err := ioutil.ReadAll(resp.Body)
if err != nil { if err != nil {
return err return err
} }
if resp.StatusCode != http.StatusOK {
return fmt.Errorf("unexpected status code returned from %q; expecting %d; got %d; response body: %q", deleteSnapshotURL, resp.StatusCode, http.StatusOK, body)
}
snap := snapshot{} snap := snapshot{}
err = json.Unmarshal(body, &snap) err = json.Unmarshal(body, &snap)