mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-11-21 14:44:00 +00:00
docs/contirubting: clarify the type of changelog line we expect
Signed-off-by: hagen1778 <roman@victoriametrics.com>
This commit is contained in:
parent
3538869942
commit
23f8ab6f81
1 changed files with 2 additions and 1 deletions
|
@ -64,7 +64,8 @@ A pull request should contain the following attributes:
|
||||||
1. Try to not extend the scope of the pull requests outside the issue, do not make unrelated changes.
|
1. Try to not extend the scope of the pull requests outside the issue, do not make unrelated changes.
|
||||||
1. Documentation update, if needed. For example, adding a new flag or changing behavior of existing flags or features
|
1. Documentation update, if needed. For example, adding a new flag or changing behavior of existing flags or features
|
||||||
requires reflecting these changes in the documentation.
|
requires reflecting these changes in the documentation.
|
||||||
1. A line in the [changelog](https://docs.victoriametrics.com/changelog/#tip) mentioning the change and related issue.
|
1. A line in the [changelog](https://docs.victoriametrics.com/changelog/#tip) mentioning the change and related issue in a way
|
||||||
|
that would be clear to other readers even if they don't have the full context.
|
||||||
1. Reviewers who you think have the best expertise on the matter.
|
1. Reviewers who you think have the best expertise on the matter.
|
||||||
|
|
||||||
See good example of pull request [here](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6487).
|
See good example of pull request [here](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6487).
|
||||||
|
|
Loading…
Reference in a new issue