github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-01-20 15:16:42 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vmselect/netstorage: cache canonical MetricName for time series returned from the storage

Browse source 
This reduces memory allocations for repeated queries, which return (almost) the same set of time series.
This commit is contained in:
Aliaksandr Valialkin 2023-01-09 21:53:07 -08:00
parent b7a4650ab0
commit 2483c67579
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/vmselect/netstorage/netstorage.go
View file

@ -1261,9 +1261,9 @@ func (tbfw *tmpBlocksFileWrapper) RegisterAndWriteBlock(mb *storage.MetricBlock,
if err != nil {
return err
}
metricName := mb.MetricName
metricName := bytesutil.InternBytes(mb.MetricName)
m := tbfw.ms[workerID]
addrs := m[string(metricName)]
addrs := m[metricName]
if addrs == nil {
addrs = &blockAddrs{}
}
@ -1272,9 +1272,8 @@ func (tbfw *tmpBlocksFileWrapper) RegisterAndWriteBlock(mb *storage.MetricBlock,
// An optimization for big number of time series with long names: store only a single copy of metricNameStr
// in both tbfw.orderedMetricNamess and tbfw.ms.
orderedMetricNames := tbfw.orderedMetricNamess[workerID]
orderedMetricNames = append(orderedMetricNames, string(metricName))
metricNameStr := orderedMetricNames[len(orderedMetricNames)-1]
m[metricNameStr] = addrs
orderedMetricNames = append(orderedMetricNames, metricName)
m[metricName] = addrs
tbfw.orderedMetricNamess[workerID] = orderedMetricNames
}
return nil