github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/{mergeset,storage}: properly fsync part directory listing after writing in-memory part to disk

Browse source 
This is a follow-up after 42bba64aa7

Previously the part directory listing was fsync'ed implicitly inside partHeader.WriteMetadata()
by calling fs.WriteFileAtomically(). Now it must be fsync'ed explicitly.

There is no need in fsync'ing the parent directory, since it is fsync'ed by the caller
when updating parts.json file.
This commit is contained in:
Aliaksandr Valialkin 2023-04-13 21:18:39 -07:00
parent 42bba64aa7
commit 25f089de9d
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1
2 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/mergeset/inmemory_part.go
View file

@ -56,9 +56,8 @@ func (mp *inmemoryPart) StoreToDisk(path string) error {
if err := mp.ph.WriteMetadata(path); err != nil {
return fmt.Errorf("cannot store metadata: %w", err)
}
// Sync parent directory in order to make sure the written files remain visible after hardware reset
parentDirPath := filepath.Dir(path)
fs.MustSyncPath(parentDirPath)
fs.MustSyncPath(path)
// Do not sync parent directory - it must be synced by the caller.
return nil
}

5
lib/storage/inmemory_part.go
View file

@ -59,9 +59,8 @@ func (mp *inmemoryPart) StoreToDisk(path string) error {
if err := mp.ph.WriteMetadata(path); err != nil {
return fmt.Errorf("cannot store metadata: %w", err)
}
// Sync parent directory in order to make sure the written files remain visible after hardware reset
parentDirPath := filepath.Dir(path)
fs.MustSyncPath(parentDirPath)
fs.MustSyncPath(path)
// Do not sync parent directory - it must be synced by the caller.
return nil
}