github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-02-09 15:27:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/storage: do not append headerData to bsw.indexData if its size exceeds maxBlockSize

Browse source 
This is a follow-up optimization after 3c246cdf00
This commit is contained in:
Aliaksandr Valialkin 2024-02-12 18:03:19 +02:00
parent 7eb5c187b3
commit 2eb967231b
No known key found for this signature in database
GPG key ID: 52C003EE2BCDB9EB
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/storage/block_stream_writer.go
View file

@ -135,6 +135,7 @@ func (bsw *blockStreamWriter) WriteExternalBlock(b *Block, ph *partHeader, rowsM
atomic.AddUint64(rowsMerged, uint64(b.rowsCount())) atomic.AddUint64(rowsMerged, uint64(b.rowsCount()))
b.deduplicateSamplesDuringMerge() b.deduplicateSamplesDuringMerge()
headerData, timestampsData, valuesData := b.MarshalData(bsw.timestampsBlockOffset, bsw.valuesBlockOffset) headerData, timestampsData, valuesData := b.MarshalData(bsw.timestampsBlockOffset, bsw.valuesBlockOffset)
usePrevTimestamps := len(bsw.prevTimestampsData) > 0 && bytes.Equal(timestampsData, bsw.prevTimestampsData) usePrevTimestamps := len(bsw.prevTimestampsData) > 0 && bytes.Equal(timestampsData, bsw.prevTimestampsData)
if usePrevTimestamps { if usePrevTimestamps {
// The current timestamps block equals to the previous timestamps block. // The current timestamps block equals to the previous timestamps block.
@ -143,14 +144,13 @@ func (bsw *blockStreamWriter) WriteExternalBlock(b *Block, ph *partHeader, rowsM
atomic.AddUint64(&timestampsBlocksMerged, 1) atomic.AddUint64(&timestampsBlocksMerged, 1)
atomic.AddUint64(&timestampsBytesSaved, uint64(len(timestampsData))) atomic.AddUint64(&timestampsBytesSaved, uint64(len(timestampsData)))
} }
indexDataLen := len(bsw.indexData)
bsw.indexData = append(bsw.indexData, headerData...) if len(bsw.indexData)+len(headerData) > maxBlockSize {
if len(bsw.indexData) > maxBlockSize {
bsw.indexData = bsw.indexData[:indexDataLen]
bsw.flushIndexData() bsw.flushIndexData()
bsw.indexData = append(bsw.indexData, headerData...)
} }
bsw.indexData = append(bsw.indexData, headerData...)
bsw.mr.RegisterBlockHeader(&b.bh) bsw.mr.RegisterBlockHeader(&b.bh)
if !usePrevTimestamps { if !usePrevTimestamps {
bsw.prevTimestampsData = append(bsw.prevTimestampsData[:0], timestampsData...) bsw.prevTimestampsData = append(bsw.prevTimestampsData[:0], timestampsData...)
bsw.prevTimestampsBlockOffset = bsw.timestampsBlockOffset bsw.prevTimestampsBlockOffset = bsw.timestampsBlockOffset