github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-03-11 15:34:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vminsert/netstorage: remove possible race condition when broken connection may be recovered before acquiring storageNode.bcLock

Browse source
This commit is contained in:
Aliaksandr Valialkin 2020-06-20 16:38:02 +03:00
parent 85036c2b07
commit 2fc2679a3f
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/vminsert/netstorage/netstorage.go
View file

@ -185,13 +185,12 @@ func sendBufToReplicas(br *bufRows, snIdx, replicas int) bool {
}
func (sn *storageNode) checkHealth() {
if !sn.isBroken() {
return
}
sn.bcLock.Lock()
defer sn.bcLock.Unlock()
if !sn.isBroken() {
return
}
if sn.bc != nil {
logger.Panicf("BUG: sn.bc must be nil when sn is broken; got %p", sn.bc)
}