github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-02-19 15:30:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

vmalert-989: return non-empty result in template func query stub to pass validation (#1002)

Browse source 
On templates validation stage vmalert does not acutally send queries, so for complex
chained expression validation may fail. To avoid this, we add a blank sample in response
so validation can pass successfully. Later, during the rule execution, stub will be replaced
with real `query` function.

https://github.com/VictoriaMetrics/VictoriaMetrics/issues/989
This commit is contained in:
Roman Khavronenko 2021-01-09 23:56:11 +00:00 committed by Aliaksandr Valialkin
parent 4ee53c3961
commit 304512b668
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/vmalert/config/testdata/rules2-good.rules vendored
View file

@ -17,6 +17,7 @@ groups:
(up == 1) (up == 1)
labels: labels:
job: '{{ $labels.job }}' job: '{{ $labels.job }}'
dynamic: '{{ $x := query "up" | first | value }}{{ if eq 1.0 $x }}one{{ else }}unknown{{ end }}'
annotations: annotations:
description: Job {{ $labels.job }} is up! description: Job {{ $labels.job }} is up!
summary: All instances up {{ range query "up" }} summary: All instances up {{ range query "up" }}

4
app/vmalert/notifier/template_func.go
View file

@ -178,7 +178,9 @@ func InitTemplateFunc(externalURL *url.URL) {
// it is present here only for validation purposes, when there is no // it is present here only for validation purposes, when there is no
// provided datasource. // provided datasource.
"query": func(q string) ([]datasource.Metric, error) { "query": func(q string) ([]datasource.Metric, error) {
return nil, nil // return non-empty slice to pass validation with chained functions in template
// see issue #989 for details
return []datasource.Metric{{}}, nil
}, },
"first": func(metrics []datasource.Metric) (datasource.Metric, error) { "first": func(metrics []datasource.Metric) (datasource.Metric, error) {
if len(metrics) > 0 { if len(metrics) > 0 {