github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-02-09 15:27:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/storage: atomically remove partitions, which went outside the configured retention

Browse source 
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3038
This commit is contained in:
Aliaksandr Valialkin 2022-09-13 13:37:34 +03:00
parent 978dcb4574
commit 340ada871d
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1
3 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/fs/fs.go
View file

@ -211,6 +211,7 @@ func MustRemoveDirAtomic(dir string) {
if err := os.Rename(dir, tmpDir); err != nil { if err := os.Rename(dir, tmpDir); err != nil {
logger.Panicf("FATAL: cannot move %s to %s: %s", dir, tmpDir, err) logger.Panicf("FATAL: cannot move %s to %s: %s", dir, tmpDir, err)
} }
MustSyncPath(dir)
MustRemoveAll(tmpDir) MustRemoveAll(tmpDir)
} }

4
lib/storage/partition.go
View file

@ -236,8 +236,8 @@ func (pt *partition) Drop() {
// Wait until all the pending transaction deletions are finished before removing partition directories. // Wait until all the pending transaction deletions are finished before removing partition directories.
pendingTxnDeletionsWG.Wait() pendingTxnDeletionsWG.Wait()
fs.MustRemoveAll(pt.smallPartsPath) fs.MustRemoveDirAtomic(pt.smallPartsPath)
fs.MustRemoveAll(pt.bigPartsPath) fs.MustRemoveDirAtomic(pt.bigPartsPath)
logger.Infof("partition %q has been dropped", pt.name) logger.Infof("partition %q has been dropped", pt.name)
} }

2
lib/storage/table.go
View file

@ -103,6 +103,7 @@ func openTable(path string, getDeletedMetricIDs func() *uint64set.Set, retention
if err := fs.MkdirAllIfNotExist(smallPartitionsPath); err != nil { if err := fs.MkdirAllIfNotExist(smallPartitionsPath); err != nil {
return nil, fmt.Errorf("cannot create directory for small partitions %q: %w", smallPartitionsPath, err) return nil, fmt.Errorf("cannot create directory for small partitions %q: %w", smallPartitionsPath, err)
} }
fs.MustRemoveTemporaryDirs(smallPartitionsPath)
smallSnapshotsPath := smallPartitionsPath + "/snapshots" smallSnapshotsPath := smallPartitionsPath + "/snapshots"
if err := fs.MkdirAllIfNotExist(smallSnapshotsPath); err != nil { if err := fs.MkdirAllIfNotExist(smallSnapshotsPath); err != nil {
return nil, fmt.Errorf("cannot create %q: %w", smallSnapshotsPath, err) return nil, fmt.Errorf("cannot create %q: %w", smallSnapshotsPath, err)
@ -113,6 +114,7 @@ func openTable(path string, getDeletedMetricIDs func() *uint64set.Set, retention
if err := fs.MkdirAllIfNotExist(bigPartitionsPath); err != nil { if err := fs.MkdirAllIfNotExist(bigPartitionsPath); err != nil {
return nil, fmt.Errorf("cannot create directory for big partitions %q: %w", bigPartitionsPath, err) return nil, fmt.Errorf("cannot create directory for big partitions %q: %w", bigPartitionsPath, err)
} }
fs.MustRemoveTemporaryDirs(bigPartitionsPath)
bigSnapshotsPath := bigPartitionsPath + "/snapshots" bigSnapshotsPath := bigPartitionsPath + "/snapshots"
if err := fs.MkdirAllIfNotExist(bigSnapshotsPath); err != nil { if err := fs.MkdirAllIfNotExist(bigSnapshotsPath); err != nil {
return nil, fmt.Errorf("cannot create %q: %w", bigSnapshotsPath, err) return nil, fmt.Errorf("cannot create %q: %w", bigSnapshotsPath, err)