github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/storage: pass pointer to MetricName in Fatalf, so it is properly detected as an interface with String() method

Browse source 
This fixes lint errors
This commit is contained in:
Aliaksandr Valialkin 2019-11-04 01:06:34 +02:00
parent 478767d0ed
commit 3c90d77858
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
lib/storage/metric_name_test.go
View file

@ -156,7 +156,7 @@ func TestMetricNameCopyFrom(t *testing.T) {
expected.AddTag("key", "value") expected.AddTag("key", "value")
if !reflect.DeepEqual(expected, to) { if !reflect.DeepEqual(expected, to) {
t.Fatalf("expecting equal metics exp: %s, got %s", expected, to) t.Fatalf("expecting equal metics exp: %s, got %s", &expected, &to)
} }
} }
@ -166,7 +166,7 @@ func TestMetricNameRemoveTagsOn(t *testing.T) {
emptyMN.AddTag("key", "value") emptyMN.AddTag("key", "value")
emptyMN.RemoveTagsOn(nil) emptyMN.RemoveTagsOn(nil)
if len(emptyMN.MetricGroup) != 0 || len(emptyMN.Tags) != 0 { if len(emptyMN.MetricGroup) != 0 || len(emptyMN.Tags) != 0 {
t.Fatalf("expecitng empty metric name got %s", emptyMN) t.Fatalf("expecitng empty metric name got %s", &emptyMN)
} }
var asIsMN MetricName var asIsMN MetricName
@ -177,7 +177,7 @@ func TestMetricNameRemoveTagsOn(t *testing.T) {
expAsIsMN.MetricGroup = []byte("name") expAsIsMN.MetricGroup = []byte("name")
expAsIsMN.AddTag("key", "value") expAsIsMN.AddTag("key", "value")
if !reflect.DeepEqual(expAsIsMN, asIsMN) { if !reflect.DeepEqual(expAsIsMN, asIsMN) {
t.Fatalf("expecitng %s got %s", expAsIsMN, asIsMN) t.Fatalf("expecitng %s got %s", &expAsIsMN, &asIsMN)
} }
var mn MetricName var mn MetricName
@ -188,7 +188,7 @@ func TestMetricNameRemoveTagsOn(t *testing.T) {
var expMN MetricName var expMN MetricName
expMN.AddTag("baz", "qux") expMN.AddTag("baz", "qux")
if !reflect.DeepEqual(expMN.Tags, mn.Tags) || len(mn.MetricGroup) != len(expMN.MetricGroup) { if !reflect.DeepEqual(expMN.Tags, mn.Tags) || len(mn.MetricGroup) != len(expMN.MetricGroup) {
t.Fatalf("expecitng %s got %s", expMN, mn) t.Fatalf("expecitng %s got %s", &expMN, &mn)
} }
} }
@ -199,13 +199,13 @@ func TestMetricNameRemoveTag(t *testing.T) {
mn.AddTag("baz", "qux") mn.AddTag("baz", "qux")
mn.RemoveTag("__name__") mn.RemoveTag("__name__")
if len(mn.MetricGroup) != 0 { if len(mn.MetricGroup) != 0 {
t.Fatalf("expecting empty metric group got %s", mn) t.Fatalf("expecting empty metric group got %s", &mn)
} }
mn.RemoveTag("foo") mn.RemoveTag("foo")
var expMN MetricName var expMN MetricName
expMN.AddTag("baz", "qux") expMN.AddTag("baz", "qux")
if !reflect.DeepEqual(expMN.Tags, mn.Tags) || len(mn.MetricGroup) != len(expMN.MetricGroup) { if !reflect.DeepEqual(expMN.Tags, mn.Tags) || len(mn.MetricGroup) != len(expMN.MetricGroup) {
t.Fatalf("expecitng %s got %s", expMN, mn) t.Fatalf("expecitng %s got %s", &expMN, &mn)
} }
} }
@ -218,6 +218,6 @@ func TestMetricNameRemoveTagsIgnoring(t *testing.T) {
var expMN MetricName var expMN MetricName
expMN.AddTag("baz", "qux") expMN.AddTag("baz", "qux")
if !reflect.DeepEqual(expMN.Tags, mn.Tags) || len(mn.MetricGroup) != len(expMN.MetricGroup) { if !reflect.DeepEqual(expMN.Tags, mn.Tags) || len(mn.MetricGroup) != len(expMN.MetricGroup) {
t.Fatalf("expecitng %s got %s", expMN, mn) t.Fatalf("expecitng %s got %s", &expMN, &mn)
} }
} }