github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/logstorage: quote logfmt strings only if they contain special chars, which could break logfmt parsing and/or reading

Browse source
This commit is contained in:
Aliaksandr Valialkin 2024-10-07 14:31:16 +02:00
parent ebd393d8b3
commit 462b7cd597
No known key found for this signature in database
GPG key ID: 52C003EE2BCDB9EB
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/logstorage/pipe_pack_logfmt_test.go
View file

@ -45,7 +45,7 @@ func TestPipePackLogfmt(t *testing.T) {
},
}, [][]Field{
{
{"_msg", `_msg=x foo=abc bar="cde=ab"`},
{"_msg", `_msg=x foo=abc bar=cde=ab`},
{"foo", `abc`},
{"bar", `cde=ab`},
},

14
lib/logstorage/rows.go
View file

@ -91,13 +91,25 @@ func getFieldValue(fields []Field, name string) string {
func needLogfmtQuoting(s string) bool {
for _, c := range s {
if !isTokenRune(c) {
if isLogfmtSpecialChar(c) {
return true
}
}
return false
}
func isLogfmtSpecialChar(c rune) bool {
if c <= 0x20 {
return true
}
switch c {
case '"', '\\':
return true
default:
return false
}
}
// RenameField renames field with the oldName to newName in Fields
func RenameField(fields []Field, oldName, newName string) {
if oldName == "" {