github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/stringsutil: fix failing test (#5313)

Browse source 
We have failed test on master branch.

```
--- FAIL: TestFormatLogMessage (0.00s)
    logger_test.go:24: unexpected result; got
        "foo: abcde, \"foo bar baz\", xx"
        want
        "foo: a..e, \"f..z\", xx"
```
if failed because maxArgs maxLen <= 4 in the  `LimitStringLen` in that case we always will return the income string
but in the test we limit the maxLen by value 4
```
f("foo: %s, %q, %s", []interface{}{"abcde", fmt.Errorf("foo bar baz"), "xx"}, 4, `foo: a..e, "f..z", xx`)
This commit is contained in:
Dmytro Kozlov 2023-11-13 09:51:49 +01:00 committed by GitHub
parent ba058a4514
commit 4722b70c89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/stringsutil/stringsutil.go
View file

@ -5,7 +5,7 @@ package stringsutil
// If len(s) > maxLen, then s is replaced with "s_prefix..s_suffix", // If len(s) > maxLen, then s is replaced with "s_prefix..s_suffix",
// so the total length of the returned string doesn't exceed maxLen. // so the total length of the returned string doesn't exceed maxLen.
func LimitStringLen(s string, maxLen int) string { func LimitStringLen(s string, maxLen int) string {
if len(s) <= maxLen || maxLen <= 4 { if len(s) <= maxLen || maxLen < 4 {
return s return s
} }
n := (maxLen / 2) - 1 n := (maxLen / 2) - 1