From 478767d0ed34b59100c45df859f3d217baf956a0 Mon Sep 17 00:00:00 2001
From: Artem Navoiev <tenmozes@gmail.com>
Date: Mon, 4 Nov 2019 00:54:46 +0200
Subject: [PATCH] add unittests for bytesutil and storage (#221)

---
 lib/bytesutil/bytesutil_test.go |  8 ++++
 lib/storage/metric_name_test.go | 79 +++++++++++++++++++++++++++++++++
 2 files changed, 87 insertions(+)

diff --git a/lib/bytesutil/bytesutil_test.go b/lib/bytesutil/bytesutil_test.go
index 29283a341..721b5c2ed 100644
--- a/lib/bytesutil/bytesutil_test.go
+++ b/lib/bytesutil/bytesutil_test.go
@@ -1,6 +1,7 @@
 package bytesutil
 
 import (
+	"bytes"
 	"testing"
 )
 
@@ -20,3 +21,10 @@ func TestResize(t *testing.T) {
 		}
 	}
 }
+
+func TestToUnsafeString(t *testing.T) {
+	s := "str"
+	if !bytes.Equal([]byte("str"), ToUnsafeBytes(s)) {
+		t.Fatalf(`[]bytes(%s) doesnt equal to %s `, s, s)
+	}
+}
diff --git a/lib/storage/metric_name_test.go b/lib/storage/metric_name_test.go
index fb8fde665..fd60a744b 100644
--- a/lib/storage/metric_name_test.go
+++ b/lib/storage/metric_name_test.go
@@ -142,3 +142,82 @@ func TestMetricNameMarshalUnmarshalRaw(t *testing.T) {
 		}
 	}
 }
+
+func TestMetricNameCopyFrom(t *testing.T) {
+	var from MetricName
+	from.MetricGroup = []byte("group")
+	from.AddTag("key", "value")
+
+	var to MetricName
+	to.CopyFrom(&from)
+
+	var expected MetricName
+	expected.MetricGroup = []byte("group")
+	expected.AddTag("key", "value")
+
+	if !reflect.DeepEqual(expected, to) {
+		t.Fatalf("expecting equal metics exp: %s, got %s", expected, to)
+	}
+}
+
+func TestMetricNameRemoveTagsOn(t *testing.T) {
+	var emptyMN MetricName
+	emptyMN.MetricGroup = []byte("name")
+	emptyMN.AddTag("key", "value")
+	emptyMN.RemoveTagsOn(nil)
+	if len(emptyMN.MetricGroup) != 0 || len(emptyMN.Tags) != 0 {
+		t.Fatalf("expecitng empty metric name got %s", emptyMN)
+	}
+
+	var asIsMN MetricName
+	asIsMN.MetricGroup = []byte("name")
+	asIsMN.AddTag("key", "value")
+	asIsMN.RemoveTagsOn([]string{"__name__", "key"})
+	var expAsIsMN MetricName
+	expAsIsMN.MetricGroup = []byte("name")
+	expAsIsMN.AddTag("key", "value")
+	if !reflect.DeepEqual(expAsIsMN, asIsMN) {
+		t.Fatalf("expecitng %s got %s", expAsIsMN, asIsMN)
+	}
+
+	var mn MetricName
+	mn.MetricGroup = []byte("name")
+	mn.AddTag("foo", "bar")
+	mn.AddTag("baz", "qux")
+	mn.RemoveTagsOn([]string{"baz"})
+	var expMN MetricName
+	expMN.AddTag("baz", "qux")
+	if !reflect.DeepEqual(expMN.Tags, mn.Tags) || len(mn.MetricGroup) != len(expMN.MetricGroup) {
+		t.Fatalf("expecitng %s got %s", expMN, mn)
+	}
+}
+
+func TestMetricNameRemoveTag(t *testing.T) {
+	var mn MetricName
+	mn.MetricGroup = []byte("name")
+	mn.AddTag("foo", "bar")
+	mn.AddTag("baz", "qux")
+	mn.RemoveTag("__name__")
+	if len(mn.MetricGroup) != 0 {
+		t.Fatalf("expecting empty metric group got %s", mn)
+	}
+	mn.RemoveTag("foo")
+	var expMN MetricName
+	expMN.AddTag("baz", "qux")
+	if !reflect.DeepEqual(expMN.Tags, mn.Tags) || len(mn.MetricGroup) != len(expMN.MetricGroup) {
+		t.Fatalf("expecitng %s got %s", expMN, mn)
+	}
+}
+
+func TestMetricNameRemoveTagsIgnoring(t *testing.T) {
+	var mn MetricName
+	mn.MetricGroup = []byte("name")
+	mn.AddTag("foo", "bar")
+	mn.AddTag("baz", "qux")
+	mn.RemoveTagsIgnoring([]string{"__name__", "foo"})
+	var expMN MetricName
+	expMN.AddTag("baz", "qux")
+	if !reflect.DeepEqual(expMN.Tags, mn.Tags) || len(mn.MetricGroup) != len(expMN.MetricGroup) {
+		t.Fatalf("expecitng %s got %s", expMN, mn)
+	}
+}