github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-01-30 15:22:07 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vminsert/common: remove obsolete optimization for reducing memory usage for InsertCtx pool

Browse source 
This optimization is no longer needed according to benchmarks with ingestion rate.

This simplifies the code a bit.
This commit is contained in:
Aliaksandr Valialkin 2024-04-20 20:38:20 +02:00
parent b36661539f
commit 498fe1cfa5
No known key found for this signature in database
GPG key ID: 52C003EE2BCDB9EB
1 changed files with 4 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
app/vminsert/netstorage/insert_ctx_pool.go
View file

@ -2,23 +2,16 @@ package netstorage
import (
"sync"
"github.com/VictoriaMetrics/VictoriaMetrics/lib/cgroup"
)
// GetInsertCtx returns InsertCtx from the pool.
//
// Call PutInsertCtx for returning it to the pool.
func GetInsertCtx() *InsertCtx {
select {
case ctx := <-insertCtxPoolCh:
return ctx
default:
if v := insertCtxPool.Get(); v != nil {
return v.(*InsertCtx)
}
return &InsertCtx{}
if v := insertCtxPool.Get(); v != nil {
return v.(*InsertCtx)
}
return &InsertCtx{}
}
// PutInsertCtx returns ctx to the pool.
@ -26,12 +19,7 @@ func GetInsertCtx() *InsertCtx {
// ctx cannot be used after the call.
func PutInsertCtx(ctx *InsertCtx) {
ctx.Reset()
select {
case insertCtxPoolCh <- ctx:
default:
insertCtxPool.Put(ctx)
}
insertCtxPool.Put(ctx)
}
var insertCtxPool sync.Pool
var insertCtxPoolCh = make(chan *InsertCtx, cgroup.AvailableCPUs())