From 4dcb6a3719ad6ac3f99cb228886aac6e9afc0c46 Mon Sep 17 00:00:00 2001 From: hagen1778 Date: Tue, 3 Sep 2024 14:23:35 +0200 Subject: [PATCH] dashboards/vmagent: fix legend captions for stream aggregation related panels. Before they were displaying wrong label names. Signed-off-by: hagen1778 --- dashboards/vm/vmagent.json | 14 +++++++------- dashboards/vmagent.json | 14 +++++++------- docs/changelog/CHANGELOG.md | 2 ++ 3 files changed, 16 insertions(+), 14 deletions(-) diff --git a/dashboards/vm/vmagent.json b/dashboards/vm/vmagent.json index c64192512..244e83f09 100644 --- a/dashboards/vm/vmagent.json +++ b/dashboards/vm/vmagent.json @@ -5088,7 +5088,7 @@ "editorMode": "code", "expr": "sum(rate(vm_streamaggr_matched_samples_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval])) without (instance, pod) > 0", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "__auto", "range": true, "refId": "A" } @@ -5184,7 +5184,7 @@ "editorMode": "code", "expr": "sum(rate(vm_streamaggr_ignored_samples_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval]) > 0) without (instance, pod)", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "__auto", "range": true, "refId": "A" } @@ -5286,7 +5286,7 @@ "editorMode": "code", "expr": "sum(rate(vm_streamaggr_output_samples_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval])) without (instance, pod) > 0", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; output={{output}}", + "legendFormat": "__auto", "range": true, "refId": "A" } @@ -5383,7 +5383,7 @@ "editorMode": "code", "expr": "increase(vm_streamaggr_flush_timeouts_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval]) > 0", "instant": false, - "legendFormat": "aggregation: {{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "aggregation: {{url}} ({{job}}): {{path}}:{{position}}", "range": true, "refId": "A" }, @@ -5396,7 +5396,7 @@ "expr": "increase(vm_streamaggr_dedup_flush_timeouts_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval]) > 0", "hide": false, "instant": false, - "legendFormat": "deduplication: {{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "deduplication: {{url}} ({{job}}): {{path}}:{{position}}", "range": true, "refId": "B" } @@ -5494,7 +5494,7 @@ "editorMode": "code", "expr": "histogram_quantile(0.99, sum(rate(vm_streamaggr_samples_lag_seconds_bucket{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval])) without (instance, pod))", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "__auto", "range": true, "refId": "A" } @@ -5591,7 +5591,7 @@ "editorMode": "code", "expr": "histogram_quantile(0.99, rate(vm_streamaggr_dedup_flush_duration_seconds_bucket{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval]))", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "__auto", "range": true, "refId": "A" } diff --git a/dashboards/vmagent.json b/dashboards/vmagent.json index 0debca079..cd26420fc 100644 --- a/dashboards/vmagent.json +++ b/dashboards/vmagent.json @@ -5087,7 +5087,7 @@ "editorMode": "code", "expr": "sum(rate(vm_streamaggr_matched_samples_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval])) without (instance, pod) > 0", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "__auto", "range": true, "refId": "A" } @@ -5183,7 +5183,7 @@ "editorMode": "code", "expr": "sum(rate(vm_streamaggr_ignored_samples_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval]) > 0) without (instance, pod)", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "__auto", "range": true, "refId": "A" } @@ -5285,7 +5285,7 @@ "editorMode": "code", "expr": "sum(rate(vm_streamaggr_output_samples_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval])) without (instance, pod) > 0", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; output={{output}}", + "legendFormat": "__auto", "range": true, "refId": "A" } @@ -5382,7 +5382,7 @@ "editorMode": "code", "expr": "increase(vm_streamaggr_flush_timeouts_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval]) > 0", "instant": false, - "legendFormat": "aggregation: {{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "aggregation: {{url}} ({{job}}): {{path}}:{{position}}", "range": true, "refId": "A" }, @@ -5395,7 +5395,7 @@ "expr": "increase(vm_streamaggr_dedup_flush_timeouts_total{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval]) > 0", "hide": false, "instant": false, - "legendFormat": "deduplication: {{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "deduplication: {{url}} ({{job}}): {{path}}:{{position}}", "range": true, "refId": "B" } @@ -5493,7 +5493,7 @@ "editorMode": "code", "expr": "histogram_quantile(0.99, sum(rate(vm_streamaggr_samples_lag_seconds_bucket{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval])) without (instance, pod))", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "__auto", "range": true, "refId": "A" } @@ -5590,7 +5590,7 @@ "editorMode": "code", "expr": "histogram_quantile(0.99, rate(vm_streamaggr_dedup_flush_duration_seconds_bucket{job=~\"$job\",instance=~\"$instance\", url=~\"$url\"}[$__rate_interval]))", "instant": false, - "legendFormat": "{{url}} ({{job}}): match={{match}}; outputs={{outputs}}", + "legendFormat": "__auto", "range": true, "refId": "A" } diff --git a/docs/changelog/CHANGELOG.md b/docs/changelog/CHANGELOG.md index 75f2da32b..418c1afa6 100644 --- a/docs/changelog/CHANGELOG.md +++ b/docs/changelog/CHANGELOG.md @@ -22,6 +22,8 @@ See also [LTS releases](https://docs.victoriametrics.com/lts-releases/). * FEATURE [stream aggregation](https://docs.victoriametrics.com/stream-aggregation/): perform deduplication for all received data when specifying `-streamAggr.dedupInterval` or `-remoteWrite.streamAggr.dedupInterval` command-line flags are set. Previously, if the `-remoteWrite.streamAggr.config` or `-streamAggr.config` is set, only series that matched aggregation config were deduplicated. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6711#issuecomment-2288361213) for details. +* BUGFIX: [vmagent dashboard](https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/dashboards/vmagent.json): fix legend captions for stream aggregation related panels. Before they were displaying wrong label names. + ## [v1.103.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.103.0) Released at 2024-08-28