From 4e0ea95f26ae6363d8c3acc486dcae5344c72ee3 Mon Sep 17 00:00:00 2001 From: Roman Khavronenko Date: Tue, 18 Oct 2022 14:27:20 +0200 Subject: [PATCH] vmalert: lower severity level for RW retries (#3237) The message about dropped data still remains at `error` level. The change supposed to make log message more clear about how serious it is. Signed-off-by: hagen1778 Signed-off-by: hagen1778 --- app/vmalert/remotewrite/remotewrite.go | 2 +- docs/CHANGELOG.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/vmalert/remotewrite/remotewrite.go b/app/vmalert/remotewrite/remotewrite.go index 943bba901..8aca17992 100644 --- a/app/vmalert/remotewrite/remotewrite.go +++ b/app/vmalert/remotewrite/remotewrite.go @@ -218,7 +218,7 @@ func (c *Client) flush(ctx context.Context, wr *prompbmarshal.WriteRequest) { return } - logger.Errorf("attempt %d to send request failed: %s", i+1, err) + logger.Warnf("attempt %d to send request failed: %s", i+1, err) // sleeping to avoid remote db hammering time.Sleep(time.Second) continue diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 553a38ff2..b49591b2f 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -42,6 +42,7 @@ The following tip changes can be tested by building VictoriaMetrics components f * FEATURE: log error if some environment variables referred at `-promscrape.config` via `%{ENV_VAR}` aren't found. This should prevent from using incorrect config files. * BUGFIX: [MetricsQL](https://docs.victoriametrics.com/MetricsQL.html): properly merge buckets with identical `le` values, but with different string representation of these values when calculating [histogram_quantile](https://docs.victoriametrics.com/MetricsQL.html#histogram_quantile) and [histogram_share](https://docs.victoriametrics.com/MetricsQL.html#histogram_share). For example, `http_request_duration_seconds_bucket{le="5"}` and `http_requests_duration_seconds_bucket{le="5.0"}`. Such buckets may be returned from distinct targets. Thanks to @647-coder for the [pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3225). +* BUGFIX: [vmalert](https://docs.victoriametrics.com/vmalert.html): change severity level for log messages about failed attempts for sending data to remote storage from `error` to `warn`. The message for about all failed send attempts remains at `error` severity level. ## [v1.82.1](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.82.1)