From 4f4bc515e0cb0d381caec36f7fa5c15c8af30ec6 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Thu, 12 Oct 2023 20:04:32 +0200 Subject: [PATCH] Revert "improve .gitignore" This reverts commit a8345bb1b9b8fc0495981e90f9c50e31374e39f5 Reason for revert: VictoriaMetrics binaries are consistently created inside `bin` directory at the root of the repository when running `make ` according to https://docs.victoriametrics.com/#how-to-build-from-sources If some dev environments create binaries inside random directories, then it is better to provide docs at https://docs.victoriametrics.com/#how-to-build-from-sources on how to setup these IDEs, so they consistently create binaries at bin/* directory at the root of the repository instead of trying to add random ignore rules inside .gitignore. As for the data directories created by VictoriaMetrics components, they may be created at random places too, so there is little sense in trying to add ignore rules for all these directories inside .gitignore. It is better to document that the built binaries must be consistently started from the repository root, so data directories are created at the repository root. The .gitignore already contains rule for blocking common data directories, which can be created by VictoriaMetrics components at the repository root. --- .gitignore | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.gitignore b/.gitignore index a5c001917..96d97c523 100644 --- a/.gitignore +++ b/.gitignore @@ -22,13 +22,3 @@ Gemfile.lock /_site _site *.tmp - -# vm binaries -app/victoria-metrics/victoria-metrics -app/vmagent/vmagent -app/vmctl/vmctl -app/vmalert/vmalert - -# vm default data folder -app/victoria-metrics/victoria-metrics-data/ -app/vmagent/vmagent-remotewrite-data/ \ No newline at end of file