github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-31 15:06:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/logstorage: small clarifications in comments

Browse source
This commit is contained in:
Aliaksandr Valialkin 2024-04-23 15:49:58 +02:00
parent 81b2fb88cc
commit 522415bf56
No known key found for this signature in database
GPG key ID: 52C003EE2BCDB9EB
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/logstorage/storage_search.go
View file

@ -122,7 +122,7 @@ type searchResultFunc func(workerID uint, br *blockResult)
// search searches for the matching rows according to so.
//
// It calls f for each found matching block.
// It calls processBlockResult for each found matching block.
func (s *Storage) search(workersCount int, so *genericSearchOptions, stopCh <-chan struct{}, processBlockResult searchResultFunc) {
// Spin up workers
var wg sync.WaitGroup
@ -179,7 +179,7 @@ func (s *Storage) search(workersCount int, so *genericSearchOptions, stopCh <-ch
close(workCh)
wg.Wait()
// Decrement references to parts
// Decrement references to parts, which were incremented inside partition.search().
for _, pw := range pws {
pw.decRef()
}
@ -277,6 +277,9 @@ func (ddb *datadb) search(pwsDst []*partWrapper, so *searchOptions, workCh chan<
pwsDst = appendPartsInTimeRange(pwsDst, ddb.inmemoryParts, so.minTimestamp, so.maxTimestamp)
pwsDst = appendPartsInTimeRange(pwsDst, ddb.fileParts, so.minTimestamp, so.maxTimestamp)
pws := pwsDst[pwsDstLen:]
// Increase references to the searched parts, so they aren't deleted during search.
// References to the searched parts must be decremented by the caller.
for _, pw := range pws {
pw.incRef()
}
@ -584,7 +587,7 @@ func getCommonTimeFilter(f filter) (*timeFilter, filter) {
for _, filter := range t.filters {
tf, ok := filter.(*timeFilter)
if ok {
// The tf must remain in af in order to properly filter out rows outside the selected time range
// The tf must remain in t.filters order to properly filter out rows outside the selected time range
return tf, f
}
}