From 527cfa2f742e10e8fc9dc60b179fcc1a638e77b7 Mon Sep 17 00:00:00 2001
From: Haleygo <hui.wang@daocloud.io>
Date: Mon, 7 Aug 2023 20:24:56 +0800
Subject: [PATCH] vmalert: fix uncleaned tmp files in tests (#4788)
---
app/vmalert/main_test.go | 1 +
app/vmalert/notifier/config_watcher_test.go | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/app/vmalert/main_test.go b/app/vmalert/main_test.go
index ace1118514..ea9be43103 100644
--- a/app/vmalert/main_test.go
+++ b/app/vmalert/main_test.go
@@ -87,6 +87,7 @@ groups:
)
f, err := os.CreateTemp("", "")
+ defer os.Remove(f.Name())
if err != nil {
t.Fatal(err)
}
diff --git a/app/vmalert/notifier/config_watcher_test.go b/app/vmalert/notifier/config_watcher_test.go
index b51cd3bfa2..921f2c3da1 100644
--- a/app/vmalert/notifier/config_watcher_test.go
+++ b/app/vmalert/notifier/config_watcher_test.go
@@ -14,6 +14,7 @@ import (
func TestConfigWatcherReload(t *testing.T) {
f, err := os.CreateTemp("", "")
+ defer os.Remove(f.Name())
if err != nil {
t.Fatal(err)
}
@@ -36,6 +37,7 @@ static_configs:
}
f2, err := os.CreateTemp("", "")
+ defer os.Remove(f2.Name())
if err != nil {
t.Fatal(err)
}
@@ -63,6 +65,7 @@ func TestConfigWatcherStart(t *testing.T) {
defer consulSDServer.Close()
consulSDFile, err := os.CreateTemp("", "")
+ defer os.Remove(consulSDFile.Name())
if err != nil {
t.Fatal(err)
}
@@ -109,6 +112,7 @@ func TestConfigWatcherReloadConcurrent(t *testing.T) {
defer consulSDServer2.Close()
consulSDFile, err := os.CreateTemp("", "")
+ defer os.Remove(consulSDFile.Name())
if err != nil {
t.Fatal(err)
}
@@ -125,6 +129,7 @@ consul_sd_configs:
`, consulSDServer1.URL, consulSDServer2.URL))
staticAndConsulSDFile, err := os.CreateTemp("", "")
+ defer os.Remove(staticAndConsulSDFile.Name())
if err != nil {
t.Fatal(err)
}