github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/storage: fall back to global inverted index if a filter match too many time series in per-day index

Browse source 
Previously this resulted to error message. The query may succeed via search in global index.
This commit is contained in:
Aliaksandr Valialkin 2019-12-03 14:46:39 +02:00
parent 6eb698d1cc
commit 534da0a8c3
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
lib/storage/index_db.go
View file

@ -2146,7 +2146,8 @@ func (is *indexSearch) tryUpdatingMetricIDsForDateRange(metricIDs *uint64set.Set
okGlobal = ok okGlobal = ok
} }
if err != nil { if err != nil {
errGlobal = fmt.Errorf("cannot search for metricIDs on date %d: %s", date, err) dateStr := time.Unix(int64(date*24*3600), 0)
errGlobal = fmt.Errorf("cannot search for metricIDs for %s: %s", dateStr, err)
} }
mu.Unlock() mu.Unlock()
}() }()
@ -2172,7 +2173,7 @@ func (is *indexSearch) tryUpdatingMetricIDsForDate(date uint64, metricIDs *uint6
} }
var result *uint64set.Set var result *uint64set.Set
maxDateMetrics := maxMetrics * 20 maxDateMetrics := maxMetrics * 50
if tfFirst == nil { if tfFirst == nil {
result = &uint64set.Set{} result = &uint64set.Set{}
if err := is.updateMetricIDsForDateAll(result, date, tfs.accountID, tfs.projectID, maxDateMetrics); err != nil { if err := is.updateMetricIDsForDateAll(result, date, tfs.accountID, tfs.projectID, maxDateMetrics); err != nil {
@ -2182,7 +2183,7 @@ func (is *indexSearch) tryUpdatingMetricIDsForDate(date uint64, metricIDs *uint6
// according to startDateForPerDayInvertedIndex. // according to startDateForPerDayInvertedIndex.
return true, nil return true, nil
} }
return false, fmt.Errorf("cannot obtain all the metricIDs for date %d: %s", date, err) return false, fmt.Errorf("cannot obtain all the metricIDs: %s", err)
} }
} else { } else {
m, err := is.getMetricIDsForDateTagFilter(tfFirst, date, tfs.commonPrefix, tfs.accountID, tfs.projectID, maxDateMetrics) m, err := is.getMetricIDsForDateTagFilter(tfFirst, date, tfs.commonPrefix, tfs.accountID, tfs.projectID, maxDateMetrics)
@ -2197,7 +2198,8 @@ func (is *indexSearch) tryUpdatingMetricIDsForDate(date uint64, metricIDs *uint6
result = m result = m
} }
if result.Len() >= maxDateMetrics { if result.Len() >= maxDateMetrics {
return false, fmt.Errorf("more than %d time series found; narrow down the query or increase `-search.maxUniqueTimeseries`", maxDateMetrics) // Too many time series found by a single tag filter. Fall back to global search.
return false, nil
} }
for i := range tfs.tfs { for i := range tfs.tfs {
@ -2215,8 +2217,8 @@ func (is *indexSearch) tryUpdatingMetricIDsForDate(date uint64, metricIDs *uint6
return false, err return false, err
} }
if m.Len() >= maxDateMetrics { if m.Len() >= maxDateMetrics {
return false, fmt.Errorf("more than %d time series found for tag filter %s; narrow down the query or increase `-search.maxUniqueTimeseries`", // Too many time series found by a single tag filter. Fall back to global search.
maxDateMetrics, tf) return false, nil
} }
if tf.isNegative { if tf.isNegative {
result.Subtract(m) result.Subtract(m)