lib/storage: log a warning when the -storageDataPath has less than -storage.minFreeDiskSpaceBytes

This should improve the debuggability of the readonly feature.

Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1727
This commit is contained in:
Aliaksandr Valialkin 2021-10-19 23:58:05 +03:00
parent bdfac4ff53
commit 53bb58ed2a
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1

View file

@ -581,10 +581,15 @@ func (s *Storage) startFreeDiskSpaceWatcher() {
freeSpaceBytes := fs.MustGetFreeSpace(s.path) freeSpaceBytes := fs.MustGetFreeSpace(s.path)
if freeSpaceBytes < freeDiskSpaceLimitBytes { if freeSpaceBytes < freeDiskSpaceLimitBytes {
// Switch the storage to readonly mode if there is no enough free space left at s.path // Switch the storage to readonly mode if there is no enough free space left at s.path
logger.Warnf("switching the storage at %s to read-only mode, since it has less than -storage.minFreeDiskSpaceBytes=%d of free space: %d bytes left",
s.path, freeDiskSpaceLimitBytes, freeSpaceBytes)
atomic.StoreUint32(&s.isReadOnly, 1) atomic.StoreUint32(&s.isReadOnly, 1)
return return
} }
atomic.StoreUint32(&s.isReadOnly, 0) if atomic.CompareAndSwapUint32(&s.isReadOnly, 1, 0) {
logger.Warnf("enabling writing to the storage at %s, since it has more than -storage.minFreeDiskSpaceBytes=%d of free space: %d bytes left",
s.path, freeDiskSpaceLimitBytes, freeSpaceBytes)
}
} }
f() f()
s.freeDiskSpaceWatcherWG.Add(1) s.freeDiskSpaceWatcherWG.Add(1)