From 5768ac0607a71f1f7efe1f4172f7b3dd9ecf0f4c Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Mon, 14 Aug 2023 15:10:00 +0200 Subject: [PATCH] lib/promrelabel: stop emitting DEBUG log lines when parsing `if` expressions These lines were accidentally left in the commit 62651570bb6142f94025266e9e65353f3d6c37e2 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4635 --- docs/CHANGELOG.md | 1 + lib/promrelabel/if_expression.go | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index e2858098d..473a0fb87 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -24,6 +24,7 @@ The following `tip` changes can be tested by building VictoriaMetrics components ## tip +* BUGFIX: remove `DEBUG` logging when parsing `if` filters inside [relabeling rules](https://docs.victoriametrics.com/vmagent.html#relabeling-enhancements) and when parsing `match` filters inside [stream aggregation rules](https://docs.victoriametrics.com/stream-aggregation.html). * BUGFIX: properly replace `:` chars in label names with `_` when `-usePromCompatibleNaming` command-line flag is passed to `vmagent`, `vminsert` or single-node VictoriaMetrics. This addresses [this comment](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3113#issuecomment-1275077071). * BUGFIX: [vmbackup](https://docs.victoriametrics.com/vmbackup.html): correctly check if specified `-dst` belongs to specified `-storageDataPath`. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4837). * BUGFIX: [vmctl](https://docs.victoriametrics.com/vmctl.html): don't interrupt the migration process if no metrics were found for a specific tenant. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4796). diff --git a/lib/promrelabel/if_expression.go b/lib/promrelabel/if_expression.go index 78519d3e8..1f3506dfb 100644 --- a/lib/promrelabel/if_expression.go +++ b/lib/promrelabel/if_expression.go @@ -80,7 +80,6 @@ func (ie *IfExpression) UnmarshalYAML(f func(interface{}) error) error { } func (ie *IfExpression) unmarshalFromInterface(v interface{}) error { - logger.Infof("DEBUG: unmarshaling ifExpr from %#v", v) ies := ie.ies[:0] switch t := v.(type) { case string: @@ -89,7 +88,6 @@ func (ie *IfExpression) unmarshalFromInterface(v interface{}) error { return fmt.Errorf("unexpected `match` option: %w", err) } ies = append(ies, ieLocal) - logger.Infof("DEBUG: unmarshaled ifExpr from %#v to %s", t, ieLocal) case []interface{}: for _, x := range t { s, ok := x.(string) @@ -102,7 +100,6 @@ func (ie *IfExpression) unmarshalFromInterface(v interface{}) error { } ies = append(ies, ieLocal) } - logger.Infof("DEBUG: unmarshaled ifExpr from %#v to %s", t, ies) default: return fmt.Errorf("unexpected `match` type; got %#v; want string or an array of strings", t) }