From 58ff914d9622a660eaa7cd318ec53b8da62f8fab Mon Sep 17 00:00:00 2001 From: hagen1778 Date: Tue, 24 Sep 2024 14:59:25 +0200 Subject: [PATCH] lib/promscrape: temporary disable TestClientProxyReadOk This test is very flaky and prevents other tests from running in CI. Disabling this test should improve tests quality, since it isn't reliable anyway. There is a ticket to fix this test - https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7062 Once fixed, this test should be uncommented. Signed-off-by: hagen1778 (cherry picked from commit c7569dac5007b3793d7b5a0b824ceb6a63a2a207) --- lib/promscrape/client_test.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/promscrape/client_test.go b/lib/promscrape/client_test.go index bafd8cd34..a9c69304f 100644 --- a/lib/promscrape/client_test.go +++ b/lib/promscrape/client_test.go @@ -1,9 +1,7 @@ package promscrape import ( - "context" "encoding/base64" - "errors" "fmt" "io" "net" @@ -12,9 +10,7 @@ import ( "testing" "time" - "github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil" "github.com/VictoriaMetrics/VictoriaMetrics/lib/promauth" - "github.com/VictoriaMetrics/VictoriaMetrics/lib/proxy" ) func copyHeader(dst, src http.Header) { @@ -113,7 +109,7 @@ func newTestAuthConfig(t *testing.T, isTLS bool, ba *promauth.BasicAuthConfig) * return ac } -func TestClientProxyReadOk(t *testing.T) { +/*func TestClientProxyReadOk(t *testing.T) { ctx := context.Background() f := func(isBackendTLS, isProxyTLS bool, backendAuth, proxyAuth *promauth.BasicAuthConfig) { t.Helper() @@ -198,4 +194,4 @@ func TestClientProxyReadOk(t *testing.T) { f(false, true, &promauth.BasicAuthConfig{Username: "test", Password: promauth.NewSecret("1234")}, nil) // backend tls and proxy auth f(true, false, nil, &promauth.BasicAuthConfig{Username: "proxy-test", Password: promauth.NewSecret("1234")}) -} +}*/