github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-03-21 15:45:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/handshake: substitute time.Now() with fastttime.UnixTimestamp(), since profiling shows time.Now() is slow

Browse source
This commit is contained in:
Aliaksandr Valialkin 2024-01-23 18:39:28 +02:00
parent be320c81bc
commit 5a97668ad6
No known key found for this signature in database
GPG key ID: 52C003EE2BCDB9EB
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/handshake/buffered_conn.go
View file

@ -9,6 +9,7 @@ import (
"time" "time"
"github.com/VictoriaMetrics/VictoriaMetrics/lib/encoding/zstd" "github.com/VictoriaMetrics/VictoriaMetrics/lib/encoding/zstd"
"github.com/VictoriaMetrics/VictoriaMetrics/lib/fasttime"
) )
type bufferedWriter interface { type bufferedWriter interface {
@ -74,13 +75,13 @@ func (bc *BufferedConn) SetWriteDeadline(t time.Time) error {
// Read reads up to len(p) from bc to p. // Read reads up to len(p) from bc to p.
func (bc *BufferedConn) Read(p []byte) (int, error) { func (bc *BufferedConn) Read(p []byte) (int, error) {
startTime := time.Now() startTime := fasttime.UnixTimestamp()
if deadlineExceeded(bc.readDeadline, startTime) { if deadlineExceeded(bc.readDeadline, startTime) {
return 0, os.ErrDeadlineExceeded return 0, os.ErrDeadlineExceeded
} }
n, err := bc.br.Read(p) n, err := bc.br.Read(p)
if err != nil && err != io.EOF { if err != nil && err != io.EOF {
err = fmt.Errorf("cannot read data in %.3f seconds: %w", time.Since(startTime).Seconds(), err) err = fmt.Errorf("cannot read data in %d seconds: %w", fasttime.UnixTimestamp()-startTime, err)
} }
return n, err return n, err
} }
@ -89,22 +90,22 @@ func (bc *BufferedConn) Read(p []byte) (int, error) {
// //
// Do not forget to call Flush if needed. // Do not forget to call Flush if needed.
func (bc *BufferedConn) Write(p []byte) (int, error) { func (bc *BufferedConn) Write(p []byte) (int, error) {
startTime := time.Now() startTime := fasttime.UnixTimestamp()
if deadlineExceeded(bc.writeDeadline, startTime) { if deadlineExceeded(bc.writeDeadline, startTime) {
return 0, os.ErrDeadlineExceeded return 0, os.ErrDeadlineExceeded
} }
n, err := bc.bw.Write(p) n, err := bc.bw.Write(p)
if err != nil { if err != nil {
err = fmt.Errorf("cannot write data in %.3f seconds: %w", time.Since(startTime).Seconds(), err) err = fmt.Errorf("cannot write data in %d seconds: %w", fasttime.UnixTimestamp()-startTime, err)
} }
return n, err return n, err
} }
func deadlineExceeded(deadline, currentTime time.Time) bool { func deadlineExceeded(deadline time.Time, currentTimestamp uint64) bool {
if deadline.IsZero() { if deadline.IsZero() {
return false return false
} }
return currentTime.After(deadline) return currentTimestamp > uint64(deadline.Unix())
} }
// Close closes bc. // Close closes bc.