github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-02-09 15:27:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/promrelabel: remove unneded optimizations for labeldrop and labelkeep actions

Browse source 
These optimizations may slow down code execution by matching the same label against regexp two times instead of a single time
This commit is contained in:
Aliaksandr Valialkin 2021-03-02 17:54:31 +02:00
parent f9c1fe3852
commit 62d7e07ff7
1 changed files with 0 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
lib/promrelabel/relabel.go
View file

@ -225,17 +225,6 @@ func (prc *parsedRelabelConfig) apply(labels []prompbmarshal.Label, labelsOffset
} }
return labels return labels
case "labeldrop": case "labeldrop":
keepSrc := true
for i := range src {
label := &src[i]
if prc.matchString(label.Name) {
keepSrc = false
break
}
}
if keepSrc {
return labels
}
dst := labels[:labelsOffset] dst := labels[:labelsOffset]
for i := range src { for i := range src {
label := &src[i] label := &src[i]
@ -245,17 +234,6 @@ func (prc *parsedRelabelConfig) apply(labels []prompbmarshal.Label, labelsOffset
} }
return dst return dst
case "labelkeep": case "labelkeep":
keepSrc := true
for i := range src {
label := &src[i]
if !prc.matchString(label.Name) {
keepSrc = false
break
}
}
if keepSrc {
return labels
}
dst := labels[:labelsOffset] dst := labels[:labelsOffset]
for i := range src { for i := range src {
label := &src[i] label := &src[i]