github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/streamaggr: prevent from data race inside dedupAggrShard when samplesBuf can be updated in pushSamples() while their values are read in the flush() loop without das.mu lock

Browse source 
This issue has been introduced in the commit 253c0cffbe
This commit is contained in:
Aliaksandr Valialkin 2024-06-11 17:30:34 +02:00
parent 4ad1f8ee3a
commit 65a97317e4
No known key found for this signature in database
GPG key ID: 52C003EE2BCDB9EB
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/streamaggr/dedup.go
View file

@ -196,7 +196,7 @@ func (das *dedupAggrShard) flush(ctx *dedupFlushCtx, f func(samples []pushSample
das.m = make(map[string]*dedupAggrSample, len(m)) das.m = make(map[string]*dedupAggrSample, len(m))
das.sizeBytes.Store(0) das.sizeBytes.Store(0)
das.itemsCount.Store(0) das.itemsCount.Store(0)
das.samplesBuf = das.samplesBuf[:0] das.samplesBuf = make([]dedupAggrSample, 0, len(das.samplesBuf))
} }
das.mu.Unlock() das.mu.Unlock()