diff --git a/docs/changelog/CHANGELOG.md b/docs/changelog/CHANGELOG.md index b9a1e5b8c..80254a6fe 100644 --- a/docs/changelog/CHANGELOG.md +++ b/docs/changelog/CHANGELOG.md @@ -32,6 +32,8 @@ See also [LTS releases](https://docs.victoriametrics.com/lts-releases/). * BUGFIX: [vmalert-tool](https://docs.victoriametrics.com/vmalert-tool/): reduce the initial health check interval for datasource. This reduces the time spent on evaluating rules by vmalert-tool. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6970). * BUGFIX: [vmalert-tool](https://docs.victoriametrics.com/vmalert-tool/): allow specifying empty labels list `labels: '{}'` in the same way as promtool does. This improves compatibility between these tools. +* BUGFIX: [VictoriaMetrics cluster](https://docs.victoriametrics.com/cluster-victoriametrics/): properly apply replication factor when storage node groups are used and replication factor is configured via global value such as `-replicationFactor=2`. Previously, global replication factor was ignored for storage node groups. See [these docs](https://docs.victoriametrics.com/cluster-victoriametrics/#vmstorage-groups-at-vmselect) for more information about storage groups configuration. + ## [v1.104.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.104.0) Released at 2024-10-02 diff --git a/lib/flagutil/dict.go b/lib/flagutil/dict.go index a7ae57393..25f5f09dd 100644 --- a/lib/flagutil/dict.go +++ b/lib/flagutil/dict.go @@ -56,6 +56,7 @@ func (di *DictInt) Set(value string) error { di.kvs = append(di.kvs, kIntValue{ v: v, }) + di.defaultValue = v return nil } for _, x := range values { diff --git a/lib/flagutil/dict_test.go b/lib/flagutil/dict_test.go index d1aebb1dc..2df07991a 100644 --- a/lib/flagutil/dict_test.go +++ b/lib/flagutil/dict_test.go @@ -109,5 +109,5 @@ func TestDictIntGet(t *testing.T) { f("foo:42", "", 123, 123) f("foo:42", "foo", 123, 42) f("532", "", 123, 532) - f("532", "foo", 123, 123) + f("532", "foo", 123, 532) }