From 676ad70d9fcaae7aab6d613a2d9ac5030015b70f Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Wed, 20 Oct 2021 00:41:02 +0300 Subject: [PATCH] lib/envflag: use flag.Set for setting the flags from env vars This should make visible the set flags at flag.Visit(), which is used later for logging and exporting the `is_set` label for these flags at /metrics page --- lib/envflag/envflag.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/envflag/envflag.go b/lib/envflag/envflag.go index 3d4014dee..e4cb5b2e2 100644 --- a/lib/envflag/envflag.go +++ b/lib/envflag/envflag.go @@ -40,7 +40,7 @@ func Parse() { // Get flag value from environment var. fname := getEnvFlagName(f.Name) if v, ok := os.LookupEnv(fname); ok { - if err := f.Value.Set(v); err != nil { + if err := flag.Set(f.Name, v); err != nil { // Do not use lib/logger here, since it is uninitialized yet. log.Fatalf("cannot set flag %s to %q, which is read from environment variable %q: %s", f.Name, v, fname, err) }