github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-03-21 15:45:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vmselect/promql: do not generate timestamps for NaN values in timestamp function according to Prometheus logic

Browse source
This commit is contained in:
Aliaksandr Valialkin 2019-09-27 18:54:32 +03:00
parent 1e6ae9eff4
commit 67d44b0845
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/vmselect/promql/exec_test.go
View file

@ -369,6 +369,17 @@ func TestExecSuccess(t *testing.T) {
resultExpected := []netstorage.Result{r} resultExpected := []netstorage.Result{r}
f(q, resultExpected) f(q, resultExpected)
}) })
t.Run("timestamp(time()>=1600)", func(t *testing.T) {
t.Parallel()
q := `timestamp(time()>=1600)`
r := netstorage.Result{
MetricName: metricNameExpected,
Values: []float64{nan, nan, nan, 1600, 1800, 2000},
Timestamps: timestampsExpected,
}
resultExpected := []netstorage.Result{r}
f(q, resultExpected)
})
t.Run("time()/100", func(t *testing.T) { t.Run("time()/100", func(t *testing.T) {
t.Parallel() t.Parallel()
q := `time()/100` q := `time()/100`

3
app/vmselect/promql/transform.go
View file

@ -1121,9 +1121,12 @@ func transformTimestamp(tfa *transformFuncArg) ([]*timeseries, error) {
ts.MetricName.ResetMetricGroup() ts.MetricName.ResetMetricGroup()
values := ts.Values values := ts.Values
for i, t := range ts.Timestamps { for i, t := range ts.Timestamps {
v := values[i]
if !math.IsNaN(v) {
values[i] = float64(t) / 1e3 values[i] = float64(t) / 1e3
} }
} }
}
return rvs, nil return rvs, nil
} }