github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-01-30 15:22:07 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vmselect/netstorage: avoid metricName->blockRef lookup when processing multiple blocks for the same time series

Browse source 
This saves a few CPU cycles for common case
This commit is contained in:
Aliaksandr Valialkin 2024-01-23 01:06:45 +02:00
parent f8a9ef8cbd
commit 68a59bfabd
No known key found for this signature in database
GPG key ID: 52C003EE2BCDB9EB
1 changed files with 20 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
app/vmselect/netstorage/netstorage.go
View file

@ -1375,6 +1375,12 @@ type tmpBlocksFileWrapperShard struct {
// orderedMetricNames contains metric names in the order of their load.
// This order is important for sequential read of data from tmpBlocksFile.
orderedMetricNames []string
// prevMetricName contains the metric name previously seen at RegisterAndWriteBlock.
prevMetricName []byte
// prevAddrsIdx contains the addrssPool index previously seen at RegisterAndWriteBlock.
prevAddrsIdx int
}
type tmpBlocksFileWrapperShardWithPadding struct {
@ -1431,13 +1437,21 @@ func (tbfw *tmpBlocksFileWrapper) RegisterAndWriteBlock(mb *storage.MetricBlock,
if err != nil {
return err
}
metricName := mb.MetricName
m := tbfwLocal.m
addrsIdx, ok := m[string(metricName)]
if !ok {
addrsIdx = tbfwLocal.newBlockAddrs()
metricName := mb.MetricName
addrsIdx := tbfwLocal.prevAddrsIdx
if tbfwLocal.prevMetricName == nil || string(metricName) != string(tbfwLocal.prevMetricName) {
idx, ok := m[string(metricName)]
if !ok {
idx = tbfwLocal.newBlockAddrs()
}
addrsIdx = idx
tbfwLocal.prevMetricName = append(tbfwLocal.prevMetricName[:0], metricName...)
tbfwLocal.prevAddrsIdx = addrsIdx
}
addrs := &tbfwLocal.addrssPool[addrsIdx]
addrsPool := tbfwLocal.addrsPool
if addrs.addrs == nil || haveSameBlockAddrTails(addrs.addrs, addrsPool) {
// It is safe appending addr to addrsPool, since there are no other items added there yet.
@ -1449,6 +1463,7 @@ func (tbfw *tmpBlocksFileWrapper) RegisterAndWriteBlock(mb *storage.MetricBlock,
// So just append it to addrs.addrs.
addrs.addrs = append(addrs.addrs, addr)
}
if len(addrs.addrs) == 1 {
metricNamesBuf := tbfwLocal.metricNamesBuf
metricNamesBufLen := len(metricNamesBuf)
@ -1462,6 +1477,7 @@ func (tbfw *tmpBlocksFileWrapper) RegisterAndWriteBlock(mb *storage.MetricBlock,
tbfwLocal.orderedMetricNames = orderedMetricNames
tbfwLocal.metricNamesBuf = metricNamesBuf
}
return nil
}