github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

remove unused comments

Browse source
This commit is contained in:
Haley Wang 2024-11-13 14:45:23 +08:00
parent 9e79fb2e11
commit 694e6a58fe
No known key found for this signature in database
GPG key ID: C6299A8A1D6CC50C
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/vmalert/rule/alerting.go
View file

@ -457,15 +457,13 @@ func (ar *AlertingRule) exec(ctx context.Context, ts time.Time, limit int) ([]pr
} }
var numActivePending int var numActivePending int
var tss []prompbmarshal.TimeSeries var tss []prompbmarshal.TimeSeries
// store alerts' labels which are `FIRING => INACTIVE`, `PENDING => INACTIVE` or `PENDING => FIRING` in this iteration,
// need to create stale time series for them later.
for h, a := range ar.alerts { for h, a := range ar.alerts {
// if alert wasn't updated in this iteration // if alert wasn't updated in this iteration
// means it is resolved already // means it is resolved already
if _, ok := updated[h]; !ok { if _, ok := updated[h]; !ok {
if a.State == notifier.StatePending { if a.State == notifier.StatePending {
// alert was in Pending state - it is not active anymore // alert was in Pending state - it is not active anymore
// add stale time series for it // add stale time series
tss = append(tss, pendingAlertStaleTimeSeries(a.Labels, ts.Unix(), true)...) tss = append(tss, pendingAlertStaleTimeSeries(a.Labels, ts.Unix(), true)...)
delete(ar.alerts, h) delete(ar.alerts, h)
@ -485,7 +483,7 @@ func (ar *AlertingRule) exec(ctx context.Context, ts time.Time, limit int) ([]pr
if ts.Sub(a.KeepFiringSince) >= ar.KeepFiringFor { if ts.Sub(a.KeepFiringSince) >= ar.KeepFiringFor {
a.State = notifier.StateInactive a.State = notifier.StateInactive
a.ResolvedAt = ts a.ResolvedAt = ts
// add stale time series for it // add stale time series
tss = append(tss, firingAlertStaleTimeSeries(a.Labels, ts.Unix())...) tss = append(tss, firingAlertStaleTimeSeries(a.Labels, ts.Unix())...)
ar.logDebugf(ts, a, "FIRING => INACTIVE: is absent in current evaluation round") ar.logDebugf(ts, a, "FIRING => INACTIVE: is absent in current evaluation round")
@ -500,7 +498,7 @@ func (ar *AlertingRule) exec(ctx context.Context, ts time.Time, limit int) ([]pr
a.Start = ts a.Start = ts
alertsFired.Inc() alertsFired.Inc()
if ar.For > 0 { if ar.For > 0 {
// add stale time series for it // add stale time series
tss = append(tss, pendingAlertStaleTimeSeries(a.Labels, ts.Unix(), false)...) tss = append(tss, pendingAlertStaleTimeSeries(a.Labels, ts.Unix(), false)...)
} }
ar.logDebugf(ts, a, "PENDING => FIRING: %s since becoming active at %v", ts.Sub(a.ActiveAt), a.ActiveAt) ar.logDebugf(ts, a, "PENDING => FIRING: %s since becoming active at %v", ts.Sub(a.ActiveAt), a.ActiveAt)