From 6cbe85a08ad0dfe7248bb616e91d2380491b64bc Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin <valyala@victoriametrics.com> Date: Thu, 8 Sep 2022 18:43:02 +0300 Subject: [PATCH] Makefile: consistently use `go install` instead of `go get` for installing various binaries needed during build/test/check of the code `go install` is the preferred way for installing go binaries starting from the minimum supported Go version for VictoriaMetrics - Go1.18 - see https://tip.golang.org/doc/go1.18#go-command --- Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 6dd5430c9..fc0c7cf1d 100644 --- a/Makefile +++ b/Makefile @@ -148,7 +148,7 @@ lint: install-golint golint app/... install-golint: - which golint || GO111MODULE=off go get golang.org/x/lint/golint + which golint || go install golang.org/x/lint/golint@latest errcheck: install-errcheck errcheck -exclude=errcheck_excludes.txt ./lib/... @@ -163,7 +163,7 @@ errcheck: install-errcheck errcheck -exclude=errcheck_excludes.txt ./app/vmctl/... install-errcheck: - which errcheck || GO111MODULE=off go get github.com/kisielk/errcheck + which errcheck || go install github.com/kisielk/errcheck@latest check-all: fmt vet lint errcheck golangci-lint govulncheck @@ -212,7 +212,7 @@ quicktemplate-gen: install-qtc qtc install-qtc: - which qtc || GO111MODULE=off go get github.com/valyala/quicktemplate/qtc + which qtc || go install github.com/valyala/quicktemplate/qtc@latest golangci-lint: install-golangci-lint @@ -228,7 +228,7 @@ install-govulncheck: which govulncheck || go install golang.org/x/vuln/cmd/govulncheck@latest install-wwhrd: - which wwhrd || GO111MODULE=off go get github.com/frapposelli/wwhrd + which wwhrd || go install github.com/frapposelli/wwhrd@latest check-licenses: install-wwhrd wwhrd check -f .wwhrd.yml