github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-03-21 15:45:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/filestream: do not measure read / write duration from / to in-memory buffers

Browse source 
Measuring read / write duration from / to in-memory buffers has little sense,
since it will be always fast. It is better to measure read / write duration from / to
real files at vm_filestream_write_duration_seconds_total and vm_filestream_read_duration_seconds_total metrics.
This also reduces overhead on time.Now() and Histogram.UpdateDuration() calls
per each filestream.Reader.Read() and filestream.Writer.Write() call when the data is read / written from / to in-memory buffers.

This is a follow-up for 2f63dec2e3
This commit is contained in:
Aliaksandr Valialkin 2024-01-23 14:48:44 +02:00
parent 41456d9569
commit 6d84b1beef
No known key found for this signature in database
GPG key ID: 52C003EE2BCDB9EB
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
lib/filestream/filestream.go
View file

@ -133,11 +133,6 @@ var (
// Read reads file contents to p. // Read reads file contents to p.
func (r *Reader) Read(p []byte) (int, error) { func (r *Reader) Read(p []byte) (int, error) {
startTime := time.Now()
defer func() {
d := time.Since(startTime).Seconds()
readDuration.Add(d)
}()
readCallsBuffered.Inc() readCallsBuffered.Inc()
n, err := r.br.Read(p) n, err := r.br.Read(p)
readBytesBuffered.Add(n) readBytesBuffered.Add(n)
@ -155,8 +150,11 @@ type statReader struct {
} }
func (sr *statReader) Read(p []byte) (int, error) { func (sr *statReader) Read(p []byte) (int, error) {
startTime := time.Now()
readCallsReal.Inc() readCallsReal.Inc()
n, err := sr.File.Read(p) n, err := sr.File.Read(p)
d := time.Since(startTime).Seconds()
readDuration.Add(d)
readBytesReal.Add(n) readBytesReal.Add(n)
return n, err return n, err
} }
@ -268,11 +266,6 @@ var (
// Write writes p to the underlying file. // Write writes p to the underlying file.
func (w *Writer) Write(p []byte) (int, error) { func (w *Writer) Write(p []byte) (int, error) {
startTime := time.Now()
defer func() {
d := time.Since(startTime).Seconds()
writeDuration.Add(d)
}()
writeCallsBuffered.Inc() writeCallsBuffered.Inc()
n, err := w.bw.Write(p) n, err := w.bw.Write(p)
writtenBytesBuffered.Add(n) writtenBytesBuffered.Add(n)
@ -309,8 +302,11 @@ type statWriter struct {
} }
func (sw *statWriter) Write(p []byte) (int, error) { func (sw *statWriter) Write(p []byte) (int, error) {
startTime := time.Now()
writeCallsReal.Inc() writeCallsReal.Inc()
n, err := sw.File.Write(p) n, err := sw.File.Write(p)
d := time.Since(startTime).Seconds()
writeDuration.Add(d)
writtenBytesReal.Add(n) writtenBytesReal.Add(n)
return n, err return n, err
} }