From 6fc2a8e5443c878c8b2945f0d0e752366a6439ce Mon Sep 17 00:00:00 2001 From: Nikolay Date: Thu, 4 Feb 2021 16:56:42 +0300 Subject: [PATCH] fixes dockerswarm (#1053) fixes improper usage of host network services https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1028 --- lib/promscrape/discovery/dockerswarm/services.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/promscrape/discovery/dockerswarm/services.go b/lib/promscrape/discovery/dockerswarm/services.go index 29e4f0dcb0..5c26ad167e 100644 --- a/lib/promscrape/discovery/dockerswarm/services.go +++ b/lib/promscrape/discovery/dockerswarm/services.go @@ -99,6 +99,11 @@ func addServicesLabels(services []service, networksLabels map[string]map[string] commonLabels["__meta_dockerswarm_service_label_"+discoveryutils.SanitizeLabelName(k)] = v } for _, vip := range service.Endpoint.VirtualIPs { + // skip services without virtual address. + // usually its host services. + if vip.Addr == "" { + continue + } ip, _, err := net.ParseCIDR(vip.Addr) if err != nil { logger.Errorf("cannot parse: %q as cidr for service label add, err: %v", vip.Addr, err)