From 71f521fc0c7be17648c950e902483074e0767efe Mon Sep 17 00:00:00 2001 From: Hui Wang Date: Wed, 20 Nov 2024 23:20:51 +0800 Subject: [PATCH] =?UTF-8?q?vmalert:=20revert=20the=20default=20value=20of?= =?UTF-8?q?=20`-remoteWrite.maxQueueSize`=20from=E2=80=A6=20(#7570)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit … `1_000_000` to `100_000` It was bumped in [v1.104.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.104.0), which increases memory usage and is not needed for most setups. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7471). --- app/vmalert/remotewrite/client.go | 2 +- docs/changelog/CHANGELOG.md | 2 ++ docs/vmalert.md | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/vmalert/remotewrite/client.go b/app/vmalert/remotewrite/client.go index 1b2ec9d38..bc7b0ea1f 100644 --- a/app/vmalert/remotewrite/client.go +++ b/app/vmalert/remotewrite/client.go @@ -27,7 +27,7 @@ var defaultConcurrency = cgroup.AvailableCPUs() * 2 const ( defaultMaxBatchSize = 1e4 - defaultMaxQueueSize = 1e6 + defaultMaxQueueSize = 1e5 defaultFlushInterval = 2 * time.Second defaultWriteTimeout = 30 * time.Second ) diff --git a/docs/changelog/CHANGELOG.md b/docs/changelog/CHANGELOG.md index b3d16330f..1d46ada13 100644 --- a/docs/changelog/CHANGELOG.md +++ b/docs/changelog/CHANGELOG.md @@ -18,6 +18,8 @@ See also [LTS releases](https://docs.victoriametrics.com/lts-releases/). ## tip +* FEATURE: [vmalert](https://docs.victoriametrics.com/vmalert): revert the default value of `-remoteWrite.maxQueueSize` from `1_000_000` to `100_000`. It was bumped in [v1.104.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.104.0), which increases memory usage and is not needed for most setups. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7471). + ## [v1.106.1](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.106.1) Released at 2024-11-15 diff --git a/docs/vmalert.md b/docs/vmalert.md index 78f051e3a..c05a7e63f 100644 --- a/docs/vmalert.md +++ b/docs/vmalert.md @@ -1384,7 +1384,7 @@ The shortlist of configuration flags is the following: -remoteWrite.maxBatchSize int Defines max number of timeseries to be flushed at once (default 10000) -remoteWrite.maxQueueSize int - Defines the max number of pending datapoints to remote write endpoint (default 1000000) + Defines the max number of pending datapoints to remote write endpoint (default 100000) -remoteWrite.oauth2.clientID string Optional OAuth2 clientID to use for -remoteWrite.url -remoteWrite.oauth2.clientSecret string