github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-01-10 15:14:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vmselect/promql: make a copy of EvalConfig when executing q1 and q2 in parallel for q1 binary_op q2

Browse source 
This should prevent from data races if the underlying functions modify EvalConfig contents.
This commit is contained in:
Aliaksandr Valialkin 2021-02-10 23:05:16 +02:00
parent 04faea8b45
commit 7a3a9421f3
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/vmselect/promql/eval.go
View file

@ -279,7 +279,8 @@ func evalExpr(ec *EvalConfig, e metricsql.Expr) ([]*timeseries, error) {
wg.Add(1)
go func() {
defer wg.Done()
tss, err := evalExpr(ec, be.Left)
ecCopy := *ec
tss, err := evalExpr(&ecCopy, be.Left)
mu.Lock()
if err != nil {
if errGlobal == nil {
@ -292,7 +293,8 @@ func evalExpr(ec *EvalConfig, e metricsql.Expr) ([]*timeseries, error) {
wg.Add(1)
go func() {
defer wg.Done()
tss, err := evalExpr(ec, be.Right)
ecCopy := *ec
tss, err := evalExpr(&ecCopy, be.Right)
mu.Lock()
if err != nil {
if errGlobal == nil {