diff --git a/app/vmselect/promql/exec_test.go b/app/vmselect/promql/exec_test.go index 67a689a67..f36e8bb2a 100644 --- a/app/vmselect/promql/exec_test.go +++ b/app/vmselect/promql/exec_test.go @@ -9491,7 +9491,7 @@ func TestNoImplicitConversionRequiredTrue(t *testing.T) { // this query will fail the test because it contains subquery // f(`aggr_over_time(("rate", "increase"), foo[1h])`) - // metricsql rollup functions + // rollup functions with extra params f(`predict_linear(foo{}[1h], 86400)`) f(`quantile_over_time(0.99, foo[1h])`) f(`quantiles_over_time("phi", 0.5, 0.99, foo[1h])`) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 347b01fbd..4fe48d50d 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -31,6 +31,8 @@ See also [LTS releases](https://docs.victoriametrics.com/lts-releases/). * FEATURE: [dashboards](https://grafana.com/orgs/victoriametrics): add [Grafana dashboard](https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/dashboards/vmauth.json) and [alerting rules](https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/deployment/docker/alerts-vmauth.yml) for [vmauth](https://docs.victoriametrics.com/vmauth/) dashboard. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4313) for details. +* BUGFIX: [vmsingle](https://docs.victoriametrics.com/single-server-victoriametrics/): properly validate rollup functions which could contain not only rollup expressions when `-search.disableImplicitConversion` or `-search.logImplicitConversion` are enabled. For example, `predict_linear(up[5m], 86400)` or `quantile_over_time(0.99, foo[1h])` will now succeed the validation if these flags are set. + ## [v1.102.0-rc2](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.102.0-rc2) Released at 2024-06-24