From 1db1a29ffabf7017aeaa4226803a857d2714faa5 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Mon, 29 Mar 2021 23:04:51 +0300 Subject: [PATCH 1/7] all: increase minimum supported Go version for building VictoriaMetrics components from v1.14 to v1.15 This is needed after the commit c0ac740f9316d6185cb8794b8deebee3f9de7d5c, which uses URL.Redacted() method, which has been added in v1.15. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1147 --- README.md | 6 +++--- app/vmagent/README.md | 4 ++-- app/vmalert/README.md | 4 ++-- app/vmauth/README.md | 2 +- app/vmbackup/README.md | 2 +- app/vmctl/README.md | 4 ++-- app/vmrestore/README.md | 2 +- docs/Cluster-VictoriaMetrics.md | 2 +- docs/Single-server-VictoriaMetrics.md | 6 +++--- docs/vmagent.md | 4 ++-- docs/vmalert.md | 4 ++-- docs/vmauth.md | 2 +- docs/vmbackup.md | 2 +- docs/vmctl.md | 4 ++-- docs/vmrestore.md | 2 +- 15 files changed, 25 insertions(+), 25 deletions(-) diff --git a/README.md b/README.md index 21fb2698f..90a9355a7 100644 --- a/README.md +++ b/README.md @@ -658,7 +658,7 @@ to your needs or when testing bugfixes. ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make victoria-metrics` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics` binary and puts it into the `bin` folder. @@ -674,7 +674,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make victoria-metrics-arm` or `make victoria-metrics-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics-arm` or `victoria-metrics-arm64` binary respectively and puts it into the `bin` folder. @@ -688,7 +688,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b `Pure Go` mode builds only Go code without [cgo](https://golang.org/cmd/cgo/) dependencies. -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make victoria-metrics-pure` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics-pure` binary and puts it into the `bin` folder. diff --git a/app/vmagent/README.md b/app/vmagent/README.md index c6ec547d9..cf52fb800 100644 --- a/app/vmagent/README.md +++ b/app/vmagent/README.md @@ -415,7 +415,7 @@ We recommend using [binary releases](https://github.com/VictoriaMetrics/Victoria ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmagent` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds the `vmagent` binary and puts it into the `bin` folder. @@ -444,7 +444,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmagent-arm` or `make vmagent-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics) It builds `vmagent-arm` or `vmagent-arm64` binary respectively and puts it into the `bin` folder. diff --git a/app/vmalert/README.md b/app/vmalert/README.md index 12e4f6179..e075f27db 100644 --- a/app/vmalert/README.md +++ b/app/vmalert/README.md @@ -390,7 +390,7 @@ It is recommended using #### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmalert` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmalert` binary and puts it into the `bin` folder. @@ -407,7 +407,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b #### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmalert-arm` or `make vmalert-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmalert-arm` or `vmalert-arm64` binary respectively and puts it into the `bin` folder. diff --git a/app/vmauth/README.md b/app/vmauth/README.md index e93cc42d2..6cb3fc6bf 100644 --- a/app/vmauth/README.md +++ b/app/vmauth/README.md @@ -110,7 +110,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmauth` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmauth` binary and puts it into the `bin` folder. diff --git a/app/vmbackup/README.md b/app/vmbackup/README.md index 2cf5fe288..811d71fae 100644 --- a/app/vmbackup/README.md +++ b/app/vmbackup/README.md @@ -235,7 +235,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmbackup` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmbackup` binary and puts it into the `bin` folder. diff --git a/app/vmctl/README.md b/app/vmctl/README.md index 313a48ec6..61813ab52 100644 --- a/app/vmctl/README.md +++ b/app/vmctl/README.md @@ -48,7 +48,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmctl` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmctl` binary and puts it into the `bin` folder. @@ -77,7 +77,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b #### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmctl-arm` or `make vmctl-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmctl-arm` or `vmctl-arm64` binary respectively and puts it into the `bin` folder. diff --git a/app/vmrestore/README.md b/app/vmrestore/README.md index 0b044ad2a..4abd1bc9c 100644 --- a/app/vmrestore/README.md +++ b/app/vmrestore/README.md @@ -131,7 +131,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmrestore` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmrestore` binary and puts it into the `bin` folder. diff --git a/docs/Cluster-VictoriaMetrics.md b/docs/Cluster-VictoriaMetrics.md index 68b729cca..88ed91695 100644 --- a/docs/Cluster-VictoriaMetrics.md +++ b/docs/Cluster-VictoriaMetrics.md @@ -96,7 +96,7 @@ vmstorage-prod ### Development Builds -1. [Install go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make` from [the repository root](https://github.com/VictoriaMetrics/VictoriaMetrics). It should build `vmstorage`, `vmselect` and `vminsert` binaries and put them into the `bin` folder. diff --git a/docs/Single-server-VictoriaMetrics.md b/docs/Single-server-VictoriaMetrics.md index 21fb2698f..90a9355a7 100644 --- a/docs/Single-server-VictoriaMetrics.md +++ b/docs/Single-server-VictoriaMetrics.md @@ -658,7 +658,7 @@ to your needs or when testing bugfixes. ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make victoria-metrics` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics` binary and puts it into the `bin` folder. @@ -674,7 +674,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make victoria-metrics-arm` or `make victoria-metrics-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics-arm` or `victoria-metrics-arm64` binary respectively and puts it into the `bin` folder. @@ -688,7 +688,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b `Pure Go` mode builds only Go code without [cgo](https://golang.org/cmd/cgo/) dependencies. -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make victoria-metrics-pure` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics-pure` binary and puts it into the `bin` folder. diff --git a/docs/vmagent.md b/docs/vmagent.md index c6ec547d9..cf52fb800 100644 --- a/docs/vmagent.md +++ b/docs/vmagent.md @@ -415,7 +415,7 @@ We recommend using [binary releases](https://github.com/VictoriaMetrics/Victoria ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmagent` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds the `vmagent` binary and puts it into the `bin` folder. @@ -444,7 +444,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmagent-arm` or `make vmagent-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics) It builds `vmagent-arm` or `vmagent-arm64` binary respectively and puts it into the `bin` folder. diff --git a/docs/vmalert.md b/docs/vmalert.md index 12e4f6179..e075f27db 100644 --- a/docs/vmalert.md +++ b/docs/vmalert.md @@ -390,7 +390,7 @@ It is recommended using #### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmalert` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmalert` binary and puts it into the `bin` folder. @@ -407,7 +407,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b #### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmalert-arm` or `make vmalert-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmalert-arm` or `vmalert-arm64` binary respectively and puts it into the `bin` folder. diff --git a/docs/vmauth.md b/docs/vmauth.md index e93cc42d2..6cb3fc6bf 100644 --- a/docs/vmauth.md +++ b/docs/vmauth.md @@ -110,7 +110,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmauth` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmauth` binary and puts it into the `bin` folder. diff --git a/docs/vmbackup.md b/docs/vmbackup.md index 2cf5fe288..811d71fae 100644 --- a/docs/vmbackup.md +++ b/docs/vmbackup.md @@ -235,7 +235,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmbackup` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmbackup` binary and puts it into the `bin` folder. diff --git a/docs/vmctl.md b/docs/vmctl.md index 313a48ec6..61813ab52 100644 --- a/docs/vmctl.md +++ b/docs/vmctl.md @@ -48,7 +48,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmctl` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmctl` binary and puts it into the `bin` folder. @@ -77,7 +77,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b #### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmctl-arm` or `make vmctl-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmctl-arm` or `vmctl-arm64` binary respectively and puts it into the `bin` folder. diff --git a/docs/vmrestore.md b/docs/vmrestore.md index 0b044ad2a..4abd1bc9c 100644 --- a/docs/vmrestore.md +++ b/docs/vmrestore.md @@ -131,7 +131,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.14. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.15. 2. Run `make vmrestore` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmrestore` binary and puts it into the `bin` folder. From 75991277fa154404c4e870494abc4258e2c5cc22 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Mon, 29 Mar 2021 23:13:00 +0300 Subject: [PATCH 2/7] Makefile: build vmutils for arm on `make release-vmutils` Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1147 --- Makefile | 12 ++++++++++++ docs/CHANGELOG.md | 2 ++ 2 files changed, 14 insertions(+) diff --git a/Makefile b/Makefile index 2cc7a0849..3f5ba9945 100644 --- a/Makefile +++ b/Makefile @@ -61,6 +61,14 @@ vmutils-arm64: \ vmrestore-arm64 \ vmctl-arm64 +vmutils-arm: \ + vmagent-arm \ + vmalert-arm \ + vmauth-arm \ + vmbackup-arm \ + vmrestore-arm \ + vmctl-arm + vmutils-windows-amd64: \ vmagent-windows-amd64 \ vmalert-windows-amd64 \ @@ -96,6 +104,7 @@ release-victoria-metrics-generic: victoria-metrics-$(GOARCH)-prod release-vmutils: \ release-vmutils-amd64 \ release-vmutils-arm64 \ + release-vmutils-arm \ release-vmutils-windows-amd64 release-vmutils-amd64: @@ -104,6 +113,9 @@ release-vmutils-amd64: release-vmutils-arm64: GOARCH=arm64 $(MAKE) release-vmutils-generic +release-vmutils-arm: + GOARCH=arm $(MAKE) release-vmutils-generic + release-vmutils-windows-amd64: GOARCH=amd64 $(MAKE) release-vmutils-windows-generic diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 2b71d7293..260b06d61 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -2,6 +2,8 @@ # tip +* FEATURE: publish vmutils for `GOOS=arm` on [releases page](https://github.com/VictoriaMetrics/VictoriaMetrics/releases). + # [v1.57.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.57.0) From 65c60cf41347e01242b8e2dbc9f4c9951eb048c9 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Mon, 29 Mar 2021 23:44:37 +0300 Subject: [PATCH 3/7] Makefile: build arm binaries on `make release-victoria-metrics` Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1147 --- Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 3f5ba9945..a92100797 100644 --- a/Makefile +++ b/Makefile @@ -85,11 +85,15 @@ release: \ release-victoria-metrics: \ release-victoria-metrics-amd64 \ + release-victoria-metrics-arm \ release-victoria-metrics-arm64 release-victoria-metrics-amd64: GOARCH=amd64 $(MAKE) release-victoria-metrics-generic +release-victoria-metrics-arm: + GOARCH=arm $(MAKE) release-victoria-metrics-generic + release-victoria-metrics-arm64: GOARCH=arm64 $(MAKE) release-victoria-metrics-generic From 7962cf1af8751bf08ab18351d4ea4bbd91c757d1 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 30 Mar 2021 13:22:21 +0300 Subject: [PATCH 4/7] app/vmselect: prevent from possible incomplete query results after timed out query Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/711 --- app/vmselect/netstorage/netstorage.go | 31 +++++++++++++-------------- docs/CHANGELOG.md | 2 ++ 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/app/vmselect/netstorage/netstorage.go b/app/vmselect/netstorage/netstorage.go index 8f1d35374..c28a8b946 100644 --- a/app/vmselect/netstorage/netstorage.go +++ b/app/vmselect/netstorage/netstorage.go @@ -82,7 +82,7 @@ func (rss *Results) mustClose() { var timeseriesWorkCh = make(chan *timeseriesWork, gomaxprocs*16) type timeseriesWork struct { - mustStop uint64 + mustStop *uint32 rss *Results pts *packedTimeseries f func(rs *Result, workerID uint) error @@ -92,7 +92,7 @@ type timeseriesWork struct { } func (tsw *timeseriesWork) reset() { - tsw.mustStop = 0 + tsw.mustStop = nil tsw.rss = nil tsw.pts = nil tsw.f = nil @@ -129,21 +129,24 @@ func timeseriesWorker(workerID uint) { var rs Result var rsLastResetTime uint64 for tsw := range timeseriesWorkCh { - rss := tsw.rss - if rss.deadline.Exceeded() { - tsw.doneCh <- fmt.Errorf("timeout exceeded during query execution: %s", rss.deadline.String()) - continue - } - if atomic.LoadUint64(&tsw.mustStop) != 0 { + if atomic.LoadUint32(tsw.mustStop) != 0 { tsw.doneCh <- nil continue } + rss := tsw.rss + if rss.deadline.Exceeded() { + atomic.StoreUint32(tsw.mustStop, 1) + tsw.doneCh <- fmt.Errorf("timeout exceeded during query execution: %s", rss.deadline.String()) + continue + } if err := tsw.pts.Unpack(&rs, rss.tbf, rss.tr, rss.fetchData); err != nil { + atomic.StoreUint32(tsw.mustStop, 1) tsw.doneCh <- fmt.Errorf("error during time series unpacking: %w", err) continue } if len(rs.Timestamps) > 0 || !rss.fetchData { if err := tsw.f(&rs, workerID); err != nil { + atomic.StoreUint32(tsw.mustStop, 1) tsw.doneCh <- err continue } @@ -171,11 +174,13 @@ func (rss *Results) RunParallel(f func(rs *Result, workerID uint) error) error { // Feed workers with work. tsws := make([]*timeseriesWork, len(rss.packedTimeseries)) + var mustStop uint32 for i := range rss.packedTimeseries { tsw := getTimeseriesWork() tsw.rss = rss tsw.pts = &rss.packedTimeseries[i] tsw.f = f + tsw.mustStop = &mustStop timeseriesWorkCh <- tsw tsws[i] = tsw } @@ -186,15 +191,9 @@ func (rss *Results) RunParallel(f func(rs *Result, workerID uint) error) error { var firstErr error rowsProcessedTotal := 0 for _, tsw := range tsws { - err := <-tsw.doneCh - if err != nil && firstErr == nil { - // Return just the first error, since other errors - // are likely duplicate the first error. + if err := <-tsw.doneCh; err != nil && firstErr == nil { + // Return just the first error, since other errors are likely duplicate the first error. firstErr = err - // Notify all the the tsws that they shouldn't be executed. - for _, tsw := range tsws { - atomic.StoreUint64(&tsw.mustStop, 1) - } } rowsProcessedTotal += tsw.rowsProcessed putTimeseriesWork(tsw) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 260b06d61..4d0aef5a5 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -4,6 +4,8 @@ * FEATURE: publish vmutils for `GOOS=arm` on [releases page](https://github.com/VictoriaMetrics/VictoriaMetrics/releases). +* BUGFIX: prevent from possible incomplete query results after timed out query. + # [v1.57.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.57.0) From d58d5562f1866791a168560f6f020b1ca1731840 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 30 Mar 2021 14:54:34 +0300 Subject: [PATCH 5/7] app/vmselect: remove `-search.storageTimeout` command-line flag, since it has the same meaning as `-search.maxQueryDuration` Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/711 --- docs/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 4d0aef5a5..37bccac9d 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -5,6 +5,7 @@ * FEATURE: publish vmutils for `GOOS=arm` on [releases page](https://github.com/VictoriaMetrics/VictoriaMetrics/releases). * BUGFIX: prevent from possible incomplete query results after timed out query. +* BUGFIX: vmselect: remove `-search.storageTimeout` command-line flag, since it has the same meaning as `-search.maxQueryDuration`. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/711#issuecomment-808884995). # [v1.57.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.57.0) From 0fe8f11090a145f1b8efd48fb18d8ebf2fa17a1b Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 30 Mar 2021 15:13:06 +0300 Subject: [PATCH 6/7] docs/CHANGELOG.md: mention about returned back `type` label for `vm_tenant_inserted_rows_total` metric See 9b4e6081996c4d1e91da73f32f5513775b39e62a --- docs/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 37bccac9d..9ede1a85d 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -6,6 +6,7 @@ * BUGFIX: prevent from possible incomplete query results after timed out query. * BUGFIX: vmselect: remove `-search.storageTimeout` command-line flag, since it has the same meaning as `-search.maxQueryDuration`. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/711#issuecomment-808884995). +* BUGFIX: vminsert: return back `type` label to per-tenant metric `vm_tenant_inserted_rows_total`. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/932). # [v1.57.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.57.0) From 2d3082bb55e9ba17084d6c5bc9ac5657db412d59 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 30 Mar 2021 15:40:06 +0300 Subject: [PATCH 7/7] docs/CHANGELOG.md: cut v1.57.1 --- docs/CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 9ede1a85d..d50bf273d 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -2,6 +2,9 @@ # tip + +# [v1.57.1](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.57.1) + * FEATURE: publish vmutils for `GOOS=arm` on [releases page](https://github.com/VictoriaMetrics/VictoriaMetrics/releases). * BUGFIX: prevent from possible incomplete query results after timed out query.