From 811f4a938075948008aaafebfbbfb761d9d8e988 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Sat, 25 Mar 2023 15:08:12 -0700 Subject: [PATCH] app/{vmbackup,vmrestore}: publish vmbackup and vmrestore binaries for Windows Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/70 --- Makefile | 10 ++++++++++ app/vmbackup/Makefile | 6 ++++++ app/vmrestore/Makefile | 6 ++++++ docs/BestPractices.md | 4 ++-- docs/CHANGELOG.md | 2 +- 5 files changed, 25 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 3cbb1bb7a..cddd06ced 100644 --- a/Makefile +++ b/Makefile @@ -141,6 +141,8 @@ vmutils-windows-amd64: \ vmagent-windows-amd64 \ vmalert-windows-amd64 \ vmauth-windows-amd64 \ + vmbackup-windows-amd64 \ + vmrestore-windows-amd64 \ vmctl-windows-amd64 victoria-metrics-crossbuild: \ @@ -309,23 +311,31 @@ release-vmutils-windows-goarch: \ vmagent-windows-$(GOARCH)-prod \ vmalert-windows-$(GOARCH)-prod \ vmauth-windows-$(GOARCH)-prod \ + vmbackup-windows-$(GOARCH)-prod \ + vmrestore-windows-$(GOARCH)-prod \ vmctl-windows-$(GOARCH)-prod cd bin && \ zip vmutils-windows-$(GOARCH)-$(PKG_TAG).zip \ vmagent-windows-$(GOARCH)-prod.exe \ vmalert-windows-$(GOARCH)-prod.exe \ vmauth-windows-$(GOARCH)-prod.exe \ + vmbackup-windows-$(GOARCH)-prod.exe \ + vmrestore-windows-$(GOARCH)-prod.exe \ vmctl-windows-$(GOARCH)-prod.exe \ && sha256sum vmutils-windows-$(GOARCH)-$(PKG_TAG).zip \ vmagent-windows-$(GOARCH)-prod.exe \ vmalert-windows-$(GOARCH)-prod.exe \ vmauth-windows-$(GOARCH)-prod.exe \ + vmbackup-windows-$(GOARCH)-prod.exe \ + vmrestore-windows-$(GOARCH)-prod.exe \ vmctl-windows-$(GOARCH)-prod.exe \ > vmutils-windows-$(GOARCH)-$(PKG_TAG)_checksums.txt cd bin && rm -rf \ vmagent-windows-$(GOARCH)-prod.exe \ vmalert-windows-$(GOARCH)-prod.exe \ vmauth-windows-$(GOARCH)-prod.exe \ + vmbackup-windows-$(GOARCH)-prod.exe \ + vmrestore-windows-$(GOARCH)-prod.exe \ vmctl-windows-$(GOARCH)-prod.exe pprof-cpu: diff --git a/app/vmbackup/Makefile b/app/vmbackup/Makefile index 87f2d5829..1e88ca68f 100644 --- a/app/vmbackup/Makefile +++ b/app/vmbackup/Makefile @@ -39,6 +39,9 @@ vmbackup-freebsd-amd64-prod: vmbackup-openbsd-amd64-prod: APP_NAME=vmbackup $(MAKE) app-via-docker-openbsd-amd64 +vmbackup-windows-amd64-prod: + APP_NAME=vmbackup $(MAKE) app-via-docker-windows-amd64 + package-vmbackup: APP_NAME=vmbackup $(MAKE) package-via-docker @@ -93,5 +96,8 @@ vmbackup-freebsd-amd64: vmbackup-openbsd-amd64: APP_NAME=vmbackup CGO_ENABLED=0 GOOS=openbsd GOARCH=amd64 $(MAKE) app-local-goos-goarch +vmbackup-windows-amd64: + GOARCH=amd64 APP_NAME=vmbackup $(MAKE) app-local-windows-goarch + vmbackup-pure: APP_NAME=vmbackup $(MAKE) app-local-pure diff --git a/app/vmrestore/Makefile b/app/vmrestore/Makefile index 5d7c2e986..824d50695 100644 --- a/app/vmrestore/Makefile +++ b/app/vmrestore/Makefile @@ -39,6 +39,9 @@ vmrestore-freebsd-amd64-prod: vmrestore-openbsd-amd64-prod: APP_NAME=vmrestore $(MAKE) app-via-docker-openbsd-amd64 +vmrestore-windows-amd64-prod: + APP_NAME=vmrestore $(MAKE) app-via-docker-windows-amd64 + package-vmrestore: APP_NAME=vmrestore $(MAKE) package-via-docker @@ -93,5 +96,8 @@ vmrestore-freebsd-amd64: vmrestore-openbsd-amd64: APP_NAME=vmrestore CGO_ENABLED=0 GOOS=openbsd GOARCH=amd64 $(MAKE) app-local-goos-goarch +vmrestore-windows-amd64: + GOARCH=amd64 APP_NAME=vmrestore $(MAKE) app-local-windows-goarch + vmrestore-pure: APP_NAME=vmrestore $(MAKE) app-local-pure diff --git a/docs/BestPractices.md b/docs/BestPractices.md index d40064d38..066c664ac 100644 --- a/docs/BestPractices.md +++ b/docs/BestPractices.md @@ -29,7 +29,7 @@ VictoriaMetrics is production-ready for the following operating systems: * OpenBSD * Solaris/SmartOS -Some VictoriaMetrics components ([vmagent](https://docs.victoriametrics.com/vmagent.html), [vmalert](https://docs.victoriametrics.com/vmalert.html) and [vmauth](https://docs.victoriametrics.com/vmauth.html)) can run on Windows. +There is an experimental support of VictoriaMetrics components for Windows. VictoriaMetrics can run also on MacOS for testing and development purposes. @@ -40,7 +40,7 @@ VictoriaMetrics can run also on MacOS for testing and development purposes. * **OpenBSD**: i386, amd64, arm * **Solaris/SmartOS**: i386, amd64 * **MacOS**: amd64, arm64 (for testing and development purposes) -* **Windows**: amd64 (supported by [vmagent](https://docs.victoriametrics.com/vmagent.html), [vmalert](https://docs.victoriametrics.com/vmalert.html) and [vmauth](https://docs.victoriametrics.com/vmauth.html)). +* **Windows**: amd64 ## Upgrade procedure diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index cb2dfba6c..2db98b47d 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -19,7 +19,7 @@ The following tip changes can be tested by building VictoriaMetrics components f so the previous versions of VictoriaMetrics will exit with the `unexpected number of substrings in the part name` error when trying to run them on the data created by v1.90.0 or newer versions. The solution is to upgrade to v1.90.0 or newer releases** -* FEATURE: publish VictoriaMetrics binaries for Windows. See [this](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3236), [this](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3821) and [this](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/70) issues. +* FEATURE: release Windows binaries for [single-node VictoriaMetrics](https://docs.victoriametrics.com/), [VictoriaMetrics cluster](https://docs.victoriametrics.com/Cluster-VictoriaMetrics.html), [vmbackup](https://docs.victoriametrics.com/vmbackup.html) and [vmrestore](https://docs.victoriametrics.com/vmrestore.html). See [this](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3236), [this](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3821) and [this](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/70) issues. * FEATURE: log metrics with truncated labels if the length of label value in the ingested metric exceeds `-maxLabelValueLen`. This should simplify debugging for this case. * FEATURE: [vmagent](https://docs.victoriametrics.com/vmagent.html): show target URL when debugging [target relabeling](https://docs.victoriametrics.com/vmagent.html#relabel-debug). This should simplify target relabel debugging a bit. See [this pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3882). * FEATURE: [vmagent](https://docs.victoriametrics.com/vmagent.html): add support for [VictoriaMetrics remote write protocol](https://docs.victoriametrics.com/vmagent.html#victoriametrics-remote-write-protocol) when [sending / receiving data to / from Kafka](https://docs.victoriametrics.com/vmagent.html#kafka-integration). This protocol allows saving egress network bandwidth costs when sending data from `vmagent` to `Kafka` located in another datacenter or availability zone. See [this feature request](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1225).