github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-03-11 15:34:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/storage: pass a single arg - rowsPerBlock - to getCompressLevel() function instead of two args

Browse source
This commit is contained in:
Aliaksandr Valialkin 2022-12-03 23:10:16 -08:00
parent bb93494eac
commit 813e8402f6
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lib/storage/partition.go
View file

@ -1157,7 +1157,8 @@ func (pt *partition) mergeParts(pws []*partWrapper, stopCh <-chan struct{}) erro
mergeIdx := pt.nextMergeIdx() mergeIdx := pt.nextMergeIdx()
tmpPartPath := fmt.Sprintf("%s/tmp/%016X", ptPath, mergeIdx) tmpPartPath := fmt.Sprintf("%s/tmp/%016X", ptPath, mergeIdx)
bsw := getBlockStreamWriter() bsw := getBlockStreamWriter()
compressLevel := getCompressLevel(outRowsCount, outBlocksCount) rowsPerBlock := float64(outRowsCount) / float64(outBlocksCount)
compressLevel := getCompressLevel(rowsPerBlock)
if err := bsw.InitFromFilePart(tmpPartPath, nocache, compressLevel); err != nil { if err := bsw.InitFromFilePart(tmpPartPath, nocache, compressLevel); err != nil {
return fmt.Errorf("cannot create destination part %q: %w", tmpPartPath, err) return fmt.Errorf("cannot create destination part %q: %w", tmpPartPath, err)
} }
@ -1277,28 +1278,27 @@ func (pt *partition) mergeParts(pws []*partWrapper, stopCh <-chan struct{}) erro
return nil return nil
} }
func getCompressLevel(rowsCount, blocksCount uint64) int { func getCompressLevel(rowsPerBlock float64) int {
avgRowsPerBlock := rowsCount / blocksCount
// See https://github.com/facebook/zstd/releases/tag/v1.3.4 about negative compression levels. // See https://github.com/facebook/zstd/releases/tag/v1.3.4 about negative compression levels.
if avgRowsPerBlock <= 10 { if rowsPerBlock <= 10 {
return -5 return -5
} }
if avgRowsPerBlock <= 50 { if rowsPerBlock <= 50 {
return -2 return -2
} }
if avgRowsPerBlock <= 200 { if rowsPerBlock <= 200 {
return -1 return -1
} }
if avgRowsPerBlock <= 500 { if rowsPerBlock <= 500 {
return 1 return 1
} }
if avgRowsPerBlock <= 1000 { if rowsPerBlock <= 1000 {
return 2 return 2
} }
if avgRowsPerBlock <= 2000 { if rowsPerBlock <= 2000 {
return 3 return 3
} }
if avgRowsPerBlock <= 4000 { if rowsPerBlock <= 4000 {
return 4 return 4
} }
return 5 return 5