From 82e34984dd404f2687aa758b2dca394cac4a6436 Mon Sep 17 00:00:00 2001
From: Aliaksandr Valialkin <valyala@victoriametrics.com>
Date: Wed, 20 Apr 2022 18:35:10 +0300
Subject: [PATCH] lib/promscrape: zero out labels after duplicate removal
inside mergeLabels()
---
lib/promscrape/config.go | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/promscrape/config.go b/lib/promscrape/config.go
index d272a43482..a994f0079c 100644
--- a/lib/promscrape/config.go
+++ b/lib/promscrape/config.go
@@ -1054,7 +1054,7 @@ func getLabelsContext() *labelsContext {
}
func putLabelsContext(lctx *labelsContext) {
- labels := lctx.labels[:cap(lctx.labels)]
+ labels := lctx.labels
for i := range labels {
labels[i].Name = ""
labels[i].Value = ""
@@ -1317,6 +1317,12 @@ func mergeLabels(dst []prompbmarshal.Label, swc *scrapeWorkConfig, target string
prevName = label.Name
}
}
+ tail := dst[len(tmp):]
+ for i := range tail {
+ label := &tail[i]
+ label.Name = ""
+ label.Value = ""
+ }
return tmp
}