From 832e0886595775784053cd89f2544350464d13b9 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Mon, 15 Jul 2024 23:38:16 +0200 Subject: [PATCH] lib/mergeset: properly update TableMetrics.TooLongItemsDroppedTotal inside Table.UpdateMetrics Substitute '+=' with '=', since tooLongItemsTotal is global counter, which doesn't belong to the Table struct. This is a follow-up for 69d244e6fba675a50b8baf29aaf4b1df2d77a454 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6297 --- lib/mergeset/table.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/mergeset/table.go b/lib/mergeset/table.go index 16d416722..f4b7edcdc 100644 --- a/lib/mergeset/table.go +++ b/lib/mergeset/table.go @@ -641,7 +641,7 @@ func (tb *Table) UpdateMetrics(m *TableMetrics) { m.IndexBlocksCacheRequests = idxbCache.Requests() m.IndexBlocksCacheMisses = idxbCache.Misses() - m.TooLongItemsDroppedTotal += tooLongItemsTotal.Load() + m.TooLongItemsDroppedTotal = tooLongItemsTotal.Load() } // AddItems adds the given items to the tb.