github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-03-11 15:34:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vmselect/promql: improve further the accuracy of buckets_limit() function

Browse source 
The accuracy is increased by mergin the smallest bucket with the smallest adjacent bucket.
This commit is contained in:
Aliaksandr Valialkin 2020-07-26 12:06:40 +03:00
parent 215eba0b82
commit 894dcb7c1c
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/vmselect/promql/exec_test.go
View file

@ -3056,6 +3056,7 @@ func TestExecSuccess(t *testing.T) {
t.Parallel() t.Parallel()
q := `sort(buckets_limit(2, ( q := `sort(buckets_limit(2, (
alias(label_set(100, "le", "inf", "x", "y"), "metric"), alias(label_set(100, "le", "inf", "x", "y"), "metric"),
alias(label_set(98, "le", "300", "x", "y"), "metric"),
alias(label_set(52, "le", "200", "x", "y"), "metric"), alias(label_set(52, "le", "200", "x", "y"), "metric"),
alias(label_set(50, "le", "120", "x", "y"), "metric"), alias(label_set(50, "le", "120", "x", "y"), "metric"),
alias(label_set(20, "le", "70", "x", "y"), "metric"), alias(label_set(20, "le", "70", "x", "y"), "metric"),
@ -3064,14 +3065,14 @@ func TestExecSuccess(t *testing.T) {
)))` )))`
r1 := netstorage.Result{ r1 := netstorage.Result{
MetricName: metricNameExpected, MetricName: metricNameExpected,
Values: []float64{50, 50, 50, 50, 50, 50}, Values: []float64{52, 52, 52, 52, 52, 52},
Timestamps: timestampsExpected, Timestamps: timestampsExpected,
} }
r1.MetricName.MetricGroup = []byte("metric") r1.MetricName.MetricGroup = []byte("metric")
r1.MetricName.Tags = []storage.Tag{ r1.MetricName.Tags = []storage.Tag{
{ {
Key: []byte("le"), Key: []byte("le"),
Value: []byte("120"), Value: []byte("200"),
}, },
{ {
Key: []byte("x"), Key: []byte("x"),

5
app/vmselect/promql/transform.go
View file

@ -363,8 +363,9 @@ func transformBucketsLimit(tfa *transformFuncArg) ([]*timeseries, error) {
xxMinIdx = i xxMinIdx = i
} }
} }
if xxMinIdx+1 == len(leGroup) { // Merge the leGroup[xxMinIdx] bucket with the smallest adjacent bucket in order to preserve
// Merge the `inf` bucket with the previous bucket in order to save accuracy. // the maximum accuracy.
if xxMinIdx+1 == len(leGroup) || (xxMinIdx > 0 && leGroup[xxMinIdx-1].hits < leGroup[xxMinIdx+1].hits) {
xxMinIdx-- xxMinIdx--
} }
leGroup[xxMinIdx+1].hits += leGroup[xxMinIdx].hits leGroup[xxMinIdx+1].hits += leGroup[xxMinIdx].hits